linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: "Rafael J. Wysocki" <rafael@kernel.org>,
	Heikki Krogerus <heikki.krogerus@linux.intel.com>,
	Linus Walleij <linus.walleij@linaro.org>,
	linux-kernel@vger.kernel.org,
	platform-driver-x86@vger.kernel.org
Subject: Re: [PATCH v3 03/13] software node: get rid of property_set_pointer()
Date: Mon, 9 Sep 2019 03:15:55 -0700	[thread overview]
Message-ID: <20190909101555.GC145199@dtor-ws> (raw)
In-Reply-To: <20190909095505.GQ2680@smile.fi.intel.com>

On Mon, Sep 09, 2019 at 12:55:05PM +0300, Andy Shevchenko wrote:
> On Mon, Sep 09, 2019 at 01:15:47AM -0700, Dmitry Torokhov wrote:
> > Instead of explicitly setting values of integer types when copying property
> > entries lets just copy entire value union when processing non-array values.
> > 
> > When handling array values assign the pointer there using the newly introduced
> > "raw" pointer union member. This allows us to remove property_set_pointer().
> 
> Is this reincarnation of 318a19718261?
> Have you read 63dcc7090137?

Okay, I think if I squash this and the followup patch to
property_get_data() then we'll only go through the "raw" pointer to get
to the non-inline data and therefore we will not have the union aliasing
issue.

The in-line values never change their type when storing/accessing.

-- 
Dmitry

  reply	other threads:[~2019-09-09 10:16 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-09  8:15 [PATCH v3 00/13] software node: add support for reference properties Dmitry Torokhov
2019-09-09  8:15 ` [PATCH v3 01/13] software node: remove DEV_PROP_MAX Dmitry Torokhov
2019-09-09  9:46   ` Andy Shevchenko
2019-09-09  8:15 ` [PATCH v3 02/13] software node: clean up property_copy_string_array() Dmitry Torokhov
2019-09-09  8:15 ` [PATCH v3 03/13] software node: get rid of property_set_pointer() Dmitry Torokhov
2019-09-09  9:55   ` Andy Shevchenko
2019-09-09 10:15     ` Dmitry Torokhov [this message]
2019-09-09 11:36       ` Andy Shevchenko
2019-09-09 13:48         ` Dmitry Torokhov
2019-09-09  8:15 ` [PATCH v3 04/13] software node: simplify property_get_pointer() Dmitry Torokhov
2019-09-09  8:15 ` [PATCH v3 05/13] software node: remove property_entry_read_uNN_array functions Dmitry Torokhov
2019-09-09  8:15 ` [PATCH v3 06/13] software node: unify PROPERTY_ENTRY_XXX macros Dmitry Torokhov
2019-09-09  8:15 ` [PATCH v3 07/13] software node: simplify property_entry_read_string_array() Dmitry Torokhov
2019-09-09  8:15 ` [PATCH v3 08/13] software node: introduce PROPERTY_ENTRY_ARRAY_XXX_LEN() Dmitry Torokhov
2019-09-09  8:15 ` [PATCH v3 09/13] efi/apple-properties: use PROPERTY_ENTRY_U8_ARRAY_LEN Dmitry Torokhov
2019-09-09  8:15 ` [PATCH v3 10/13] software node: rename is_array to is_inline Dmitry Torokhov
2019-09-09  8:15 ` [PATCH v3 11/13] software node: implement reference properties Dmitry Torokhov
2019-09-09  8:15 ` [PATCH v3 12/13] platform/x86: intel_cht_int33fe: use inline " Dmitry Torokhov
2019-09-09  8:15 ` [PATCH v3 13/13] software node: remove separate handling of references Dmitry Torokhov
2019-10-11  9:20 ` [PATCH v3 00/13] software node: add support for reference properties Rafael J. Wysocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190909101555.GC145199@dtor-ws \
    --to=dmitry.torokhov@gmail.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=heikki.krogerus@linux.intel.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=platform-driver-x86@vger.kernel.org \
    --cc=rafael@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).