From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 00928C49ED6 for ; Mon, 9 Sep 2019 14:17:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CC562206CD for ; Mon, 9 Sep 2019 14:17:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Flbcx2BC" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731312AbfIIORp (ORCPT ); Mon, 9 Sep 2019 10:17:45 -0400 Received: from mail-wm1-f68.google.com ([209.85.128.68]:38507 "EHLO mail-wm1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730690AbfIIORo (ORCPT ); Mon, 9 Sep 2019 10:17:44 -0400 Received: by mail-wm1-f68.google.com with SMTP id o184so14888857wme.3 for ; Mon, 09 Sep 2019 07:17:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:date:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=2qb5xUYiQ7B8gJNTYidGOmiStSSf8Mji6z+Cq9akdzo=; b=Flbcx2BCt5vaMvdtOI3H+Teqq4mwUXKD+Vl4eF5nM5MnB25gGA7qaHWiUmW4867wb7 meo/YTmyrqM0PAwLwQFIBsfqCf522XecZkUj5Z3UuZyGYZqIISZWW+WOGmnEDWnow1b7 HWqpVnNPEdZaqDTudQ+INYo05gBQETKL5j4ibd3js4cA7j3Sw5ll5/cqBtMoYYmnSM8l 3o3vyibK1sSuOhgSy3pxPnIN2KEqjy+l0e4YU8wA+GL+6P5Xl7GjnhgYZ81Ezh9f+t/E svHOSKVSGKWAjz2Ui5K+YbgUbRVo1k1ka6cFmWe9IixwWPVXZnVsba3XdRXgrS6JmdRB RoLw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:date:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=2qb5xUYiQ7B8gJNTYidGOmiStSSf8Mji6z+Cq9akdzo=; b=UwD1Nktci/u5fA4Pgzdzg6lxY1oHoaQVL6vKqY3wRPEtJt5YEcHLGCPtkpSU1cVR/l iPYDKV5C+bxjpESHsgJH8XE1fsugqL3i6kRILHQMpTDxYXdRbCDwpqZWEpI/qCULAUmv guz6nQP31EQlwiI2nufNHLeIqB/DPMGjaOkOv6BZc+b6vNPUX1y6wyxEEIXQ7n+J4EgI gWmExlFdCrv+ny7d8GDxOk26wnd0Itlo1HaA9TpqyuVOn/tTqRk1bRPQdN2CQQEo42XN Q/7sT0fBhCm2cdCBAx+JZepz/xLKQdegxpoLKbqFtCMCt3xfwukTDRvt+KWjMZlnZzql dKrA== X-Gm-Message-State: APjAAAVnG8JdfKzS98otSY2MS/68xVyHCJAea96tZ5Guw9YHTneynGZW 2jPTOZySgWYGhkbzsf79dBF9JQ== X-Google-Smtp-Source: APXvYqxDvIFV/NVWVLGmp7FjrlkvLwAO5iOMBuEdJaZBZlUzZur45Ig1Y1u68ulDq2RQcMpTNRH5nQ== X-Received: by 2002:a7b:cc82:: with SMTP id p2mr18607472wma.165.1568038662629; Mon, 09 Sep 2019 07:17:42 -0700 (PDT) Received: from igloo (69.red-83-35-113.dynamicip.rima-tde.net. [83.35.113.69]) by smtp.gmail.com with ESMTPSA id d9sm22225290wrc.44.2019.09.09.07.17.41 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 09 Sep 2019 07:17:41 -0700 (PDT) From: "Jorge Ramirez-Ortiz, Linaro" X-Google-Original-From: "Jorge Ramirez-Ortiz, Linaro" Date: Mon, 9 Sep 2019 16:17:40 +0200 To: Stephen Boyd Cc: agross@kernel.org, jorge.ramirez-ortiz@linaro.org, mturquette@baylibre.com, bjorn.andersson@linaro.org, niklas.cassel@linaro.org, linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/5] clk: qcom: apcs-msm8916: get parent clock names from DT Message-ID: <20190909141740.GA23964@igloo> References: <20190826164510.6425-1-jorge.ramirez-ortiz@linaro.org> <20190826164510.6425-2-jorge.ramirez-ortiz@linaro.org> <20190909102117.245112089F@mail.kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190909102117.245112089F@mail.kernel.org> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/09/19 03:21:16, Stephen Boyd wrote: > Quoting Jorge Ramirez-Ortiz (2019-08-26 09:45:07) > > @@ -76,10 +88,11 @@ static int qcom_apcs_msm8916_clk_probe(struct platform_device *pdev) > > a53cc->src_shift = 8; > > a53cc->parent_map = gpll0_a53cc_map; > > > > - a53cc->pclk = devm_clk_get(parent, NULL); > > + a53cc->pclk = of_clk_get(parent->of_node, pll_index); > > Presumably the PLL was always index 0, so why are we changing it to > index 1 sometimes? Seems unnecessary. > it came as a personal preference. hope it is acceptable (I would rather not change it) apcs-msm8916.c declares the following [..] static const u32 gpll0_a53cc_map[] = { 4, 5 }; static const char *gpll0_a53cc[] = { "gpll0_vote", "a53pll", }; [..] now will be doing this --- a/arch/arm64/boot/dts/qcom/msm8916.dtsi +++ b/arch/arm64/boot/dts/qcom/msm8916.dtsi @@ -429,7 +429,8 @@ compatible = "qcom,msm8916-apcs-kpss-global", "syscon"; reg = <0xb011000 0x1000>; #mbox-cells = <1>; - clocks = <&a53pll>; + clocks = <&gcc GPLL0_VOTE>, <&a53pll>; + clock-names = "aux", "pll"; #clock-cells = <0>; }; so I chose to keep the consistency between the clocks definition and just change the index before calling of_clk_get.