From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3EBFDC49ED7 for ; Tue, 10 Sep 2019 17:25:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1F97720872 for ; Tue, 10 Sep 2019 17:25:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2437088AbfIJRZY (ORCPT ); Tue, 10 Sep 2019 13:25:24 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:59808 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2394139AbfIJRZY (ORCPT ); Tue, 10 Sep 2019 13:25:24 -0400 Received: from localhost (unknown [88.214.187.211]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id D7F24154FE282; Tue, 10 Sep 2019 10:25:21 -0700 (PDT) Date: Tue, 10 Sep 2019 19:25:16 +0200 (CEST) Message-Id: <20190910.192516.1686418457520996592.davem@davemloft.net> To: tanhuazhong@huawei.com Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, salil.mehta@huawei.com, yisen.zhuang@huawei.com, linuxarm@huawei.com, jakub.kicinski@netronome.com, huangguangbin2@huawei.com Subject: Re: [PATCH net-next 1/7] net: hns3: add ethtool_ops.set_channels support for HNS3 VF driver From: David Miller In-Reply-To: <1568105908-60983-2-git-send-email-tanhuazhong@huawei.com> References: <1568105908-60983-1-git-send-email-tanhuazhong@huawei.com> <1568105908-60983-2-git-send-email-tanhuazhong@huawei.com> X-Mailer: Mew version 6.8 on Emacs 26.2 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 10 Sep 2019 10:25:23 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Huazhong Tan Date: Tue, 10 Sep 2019 16:58:22 +0800 > + /* Set to user value, no larger than max_rss_size. */ > + if (kinfo->req_rss_size != kinfo->rss_size && kinfo->req_rss_size && > + kinfo->req_rss_size <= max_rss_size) { > + dev_info(&hdev->pdev->dev, "rss changes from %u to %u\n", > + kinfo->rss_size, kinfo->req_rss_size); > + kinfo->rss_size = kinfo->req_rss_size; Please do not emit kernel log messages for normal operations.