From: Kees Cook <keescook@chromium.org>
To: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
Cc: 20190819234111.9019-8-keescook@chromium.org,
Andrew Morton <akpm@linux-foundation.org>,
Christophe Leroy <christophe.leroy@c-s.fr>,
Peter Zijlstra <peterz@infradead.org>,
Drew Davenport <ddavenport@chromium.org>,
Arnd Bergmann <arnd@arndb.de>,
"Steven Rostedt (VMware)" <rostedt@goodmis.org>,
Feng Tang <feng.tang@intel.com>, Petr Mladek <pmladek@suse.com>,
Mauro Carvalho Chehab <mchehab+samsung@kernel.org>,
Borislav Petkov <bp@suse.de>, YueHaibing <yuehaibing@huawei.com>,
linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 7/7] bug: Move WARN_ON() "cut here" into exception handler
Date: Tue, 10 Sep 2019 01:59:30 -0700 [thread overview]
Message-ID: <201909100157.CEE99802C@keescook> (raw)
In-Reply-To: <20190909160539.GA989@tigerII.localdomain>
On Tue, Sep 10, 2019 at 01:05:39AM +0900, Sergey Senozhatsky wrote:
> On (08/20/19 09:47), Kees Cook wrote:
> [..]
> > @@ -181,6 +181,15 @@ enum bug_trap_type report_bug(unsigned long bugaddr, struct pt_regs *regs)
> > }
> > }
> >
> > + /*
> > + * BUG() and WARN_ON() families don't print a custom debug message
> > + * before triggering the exception handler, so we must add the
> > + * "cut here" line now. WARN() issues its own "cut here" before the
> > + * extra debugging message it writes before triggering the handler.
> > + */
> > + if ((bug->flags & BUGFLAG_NO_CUT_HERE) == 0)
> > + printk(KERN_DEFAULT CUT_HERE);
>
> Shouldn't this be pr_warn() or pr_crit()?
The pr_* helpers here would (potentially) add unwanted prefixes, so
those aren't used. KERN_DEFAULT is used here because that's how it's
always been printed. I didn't want to change that for this refactoring
work. I'm not opposed to it, generally speaking, though. :)
--
Kees Cook
next prev parent reply other threads:[~2019-09-10 8:59 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-20 16:47 [PATCH v2 7/7] bug: Move WARN_ON() "cut here" into exception handler Kees Cook
2019-08-22 22:56 ` Andrew Morton
2019-08-23 14:26 ` Christophe Leroy
2019-08-24 19:08 ` Kees Cook
2019-08-29 4:55 ` Christophe Leroy
2019-08-29 16:12 ` Kees Cook
2019-08-23 14:56 ` Christophe Leroy
2019-09-09 16:05 ` Sergey Senozhatsky
2019-09-10 8:59 ` Kees Cook [this message]
2019-09-10 9:16 ` Sergey Senozhatsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201909100157.CEE99802C@keescook \
--to=keescook@chromium.org \
--cc=20190819234111.9019-8-keescook@chromium.org \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=bp@suse.de \
--cc=christophe.leroy@c-s.fr \
--cc=ddavenport@chromium.org \
--cc=feng.tang@intel.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab+samsung@kernel.org \
--cc=peterz@infradead.org \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
--cc=sergey.senozhatsky@gmail.com \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).