From: Jean-Jacques Hiblot <jjhiblot@ti.com> To: <jacek.anaszewski@gmail.com>, <pavel@ucw.cz>, <robh+dt@kernel.org>, <mark.rutland@arm.com>, <lee.jones@linaro.org>, <daniel.thompson@linaro.org> Cc: <dmurphy@ti.com>, <linux-leds@vger.kernel.org>, <linux-kernel@vger.kernel.org>, <dridevel@lists.freedesktop.org>, <tomi.valkeinen@ti.com>, Jean-Jacques Hiblot <jjhiblot@ti.com> Subject: [PATCH v5 1/4] leds: Add of_led_get() and led_put() Date: Tue, 10 Sep 2019 12:59:43 +0200 [thread overview] Message-ID: <20190910105946.23057-2-jjhiblot@ti.com> (raw) In-Reply-To: <20190910105946.23057-1-jjhiblot@ti.com> From: Tomi Valkeinen <tomi.valkeinen@ti.com> This patch adds basic support for a kernel driver to get a LED device. This will be used by the led-backlight driver. Only OF version is implemented for now, and the behavior is similar to PWM's of_pwm_get() and pwm_put(). Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com> Signed-off-by: Jean-Jacques Hiblot <jjhiblot@ti.com> Acked-by: Pavel Machek <pavel@ucw.cz> --- drivers/leds/led-class.c | 50 ++++++++++++++++++++++++++++++++++++++++ include/linux/leds.h | 4 ++++ 2 files changed, 54 insertions(+) diff --git a/drivers/leds/led-class.c b/drivers/leds/led-class.c index 4e2af8df5aa8..eb98bf13e53b 100644 --- a/drivers/leds/led-class.c +++ b/drivers/leds/led-class.c @@ -18,6 +18,7 @@ #include <linux/spinlock.h> #include <linux/timer.h> #include <uapi/linux/uleds.h> +#include <linux/of.h> #include "leds.h" static struct class *leds_class; @@ -213,6 +214,55 @@ static int led_resume(struct device *dev) static SIMPLE_DEV_PM_OPS(leds_class_dev_pm_ops, led_suspend, led_resume); +static int led_match_led_node(struct device *led_dev, const void *data) +{ + return led_dev->of_node == data; +} + +/** + * of_led_get() - request a LED device via the LED framework + * @np: device node to get the LED device from + * @index: the index of the LED + * + * Returns the LED device parsed from the phandle specified in the "leds" + * property of a device tree node or a negative error-code on failure. + */ +struct led_classdev *of_led_get(struct device_node *np, int index) +{ + struct device *led_dev; + struct led_classdev *led_cdev; + struct device_node *led_node; + + led_node = of_parse_phandle(np, "leds", index); + if (!led_node) + return ERR_PTR(-ENOENT); + + led_dev = class_find_device(leds_class, NULL, led_node, + led_match_led_node); + of_node_put(led_node); + + if (!led_dev) + return ERR_PTR(-EPROBE_DEFER); + + led_cdev = dev_get_drvdata(led_dev); + + if (!try_module_get(led_cdev->dev->parent->driver->owner)) + return ERR_PTR(-ENODEV); + + return led_cdev; +} +EXPORT_SYMBOL_GPL(of_led_get); + +/** + * led_put() - release a LED device + * @led_cdev: LED device + */ +void led_put(struct led_classdev *led_cdev) +{ + module_put(led_cdev->dev->parent->driver->owner); +} +EXPORT_SYMBOL_GPL(led_put); + static int match_name(struct device *dev, const void *data) { if (!dev_name(dev)) diff --git a/include/linux/leds.h b/include/linux/leds.h index bee8e3f8dddd..0a71c7cdd191 100644 --- a/include/linux/leds.h +++ b/include/linux/leds.h @@ -19,6 +19,7 @@ struct device; struct led_pattern; +struct device_node; /* * LED Core */ @@ -145,6 +146,9 @@ extern void devm_led_classdev_unregister(struct device *parent, extern void led_classdev_suspend(struct led_classdev *led_cdev); extern void led_classdev_resume(struct led_classdev *led_cdev); +extern struct led_classdev *of_led_get(struct device_node *np, int index); +extern void led_put(struct led_classdev *led_cdev); + /** * led_blink_set - set blinking with software fallback * @led_cdev: the LED to start blinking -- 2.17.1
next prev parent reply other threads:[~2019-09-10 11:00 UTC|newest] Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-09-10 10:59 [PATCH v5 0/4] Add a generic driver for LED-based backlight Jean-Jacques Hiblot 2019-09-10 10:59 ` Jean-Jacques Hiblot [this message] 2019-09-10 10:59 ` [PATCH v5 2/4] leds: Add managed API to get a LED from a device driver Jean-Jacques Hiblot 2019-09-10 10:59 ` [PATCH v5 3/4] dt-bindings: backlight: Add led-backlight binding Jean-Jacques Hiblot 2019-09-10 11:26 ` Daniel Thompson 2019-09-10 10:59 ` [PATCH v5 4/4] backlight: add led-backlight driver Jean-Jacques Hiblot 2019-09-10 11:26 ` Daniel Thompson 2019-09-10 11:38 ` Jean-Jacques Hiblot 2019-09-10 11:39 ` Daniel Thompson
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20190910105946.23057-2-jjhiblot@ti.com \ --to=jjhiblot@ti.com \ --cc=daniel.thompson@linaro.org \ --cc=dmurphy@ti.com \ --cc=dridevel@lists.freedesktop.org \ --cc=jacek.anaszewski@gmail.com \ --cc=lee.jones@linaro.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-leds@vger.kernel.org \ --cc=mark.rutland@arm.com \ --cc=pavel@ucw.cz \ --cc=robh+dt@kernel.org \ --cc=tomi.valkeinen@ti.com \ --subject='Re: [PATCH v5 1/4] leds: Add of_led_get() and led_put()' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).