linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Sandro Volery LKML <lkml.sandro@volery.com>
Cc: Sandro Volery <sandro@volery.com>,
	devel@driverdev.osuosl.org, gregkh@linuxfoundation.org,
	linux-kernel@vger.kernel.org, rspringer@google.com,
	joe@perches.com, toddpoynor@google.com
Subject: Re: [PATCH v2] Staging: gasket: Use temporaries to reduce line length.
Date: Tue, 10 Sep 2019 14:27:00 +0300	[thread overview]
Message-ID: <20190910112700.GB30834@kadam> (raw)
In-Reply-To: <73C0743C-6864-4868-829B-D567F12A9463@volery.com>

On Tue, Sep 10, 2019 at 07:11:26AM +0200, Sandro Volery LKML wrote:
> Wow... I checked, compiled and still sent the wrong thing again. I'm
> gonna have to give this up soon if i can't get it right.
> 

The mistake was using gasket_page_table_num_simple_entries() instead
of gasket_page_table_num_entries()?

When I write a patch, I always queue it up and the let it sit in my
outbox overnight so I can review it again in the morning.  Otherwise my
mind is clouded with other emotions and I can't review objectively.
There is never a rush.

> Sandro V
> 
> > On 10 Sep 2019, at 07:06, Sandro Volery <sandro@volery.com> wrote:
> > 
> > Using temporaries for gasket_page_table entries to remove scnprintf()
> > statements and reduce line length, as suggested by Joe Perches. Thanks!
                                                                    ^^^^^^^

Don't put this in the commit log.  :P

regards,
dan carpenter


      reply	other threads:[~2019-09-10 11:27 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-10  5:05 [PATCH v2] Staging: gasket: Use temporaries to reduce line length Sandro Volery
2019-09-10  5:11 ` Sandro Volery LKML
2019-09-10 11:27   ` Dan Carpenter [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190910112700.GB30834@kadam \
    --to=dan.carpenter@oracle.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=joe@perches.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lkml.sandro@volery.com \
    --cc=rspringer@google.com \
    --cc=sandro@volery.com \
    --cc=toddpoynor@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).