* Re: [PATCH 3/3] spi: mediatek: support large PA
[not found] ` <1568195731-3239-4-git-send-email-luhua.xu@mediatek.com>
@ 2019-09-11 10:03 ` Mark Brown
0 siblings, 0 replies; only message in thread
From: Mark Brown @ 2019-09-11 10:03 UTC (permalink / raw)
To: Luhua Xu
Cc: Rob Herring, Mark Rutland, Matthias Brugger, linux-spi,
devicetree, linux-arm-kernel, linux-mediatek, linux-kernel,
wsd_upstream
[-- Attachment #1: Type: text/plain, Size: 341 bytes --]
On Wed, Sep 11, 2019 at 05:55:31AM -0400, Luhua Xu wrote:
> + ret = dma_set_mask(&pdev->dev, DMA_BIT_MASK(addr_bits));
> + if (ret)
> + dev_notice(&pdev->dev, "SPI dma_set_mask(%d) failed, ret:%d\n",
> + addr_bits, ret);
Not sure why you picked dev_notice() over dev_err() here?
Otherwise this looks good so I'll go ahead and apply.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2019-09-11 10:03 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <1568195731-3239-1-git-send-email-luhua.xu@mediatek.com>
[not found] ` <1568195731-3239-4-git-send-email-luhua.xu@mediatek.com>
2019-09-11 10:03 ` [PATCH 3/3] spi: mediatek: support large PA Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).