From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 39BC8C5ACAE for ; Wed, 11 Sep 2019 10:25:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0B0BC2082C for ; Wed, 11 Sep 2019 10:25:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="WbGo5Hmz" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727704AbfIKKZi (ORCPT ); Wed, 11 Sep 2019 06:25:38 -0400 Received: from mail-wm1-f65.google.com ([209.85.128.65]:53927 "EHLO mail-wm1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727677AbfIKKZh (ORCPT ); Wed, 11 Sep 2019 06:25:37 -0400 Received: by mail-wm1-f65.google.com with SMTP id q18so2776118wmq.3 for ; Wed, 11 Sep 2019 03:25:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=cVytbu5aDeImYPKa8pGIMJDrGZ6PUWapgttWO1YNSWo=; b=WbGo5Hmz09242kK2X2Ks5uKjFCYXNT2i6lWaWWpoIN+qvvLyXoNLqTsd/1nDidIfV2 DQVN4B+puM2xskQIoKsxbaSQMlx9AiUrOLwVDieIgFbBoCitWqznFjicK88E/v9xXS3K BN25w/Fa6IfYNrZLdGgUIYPdCBhRgedhJ/2rGI2IPa0QIANFJ5kDHIWvhJOGlaWJb2aV w6whG54hVEfGCDgCh4JWZz3XIQN8XzZiMzmPQohhgPvGydLLkQGve+NqCWI7yeFo9olm CelxyfcqCEsPYLNMEvfPEQA+NH12WAoyHPk8tORRcyaFb0AOnBbf6TX6tapfMVeOj2to danw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=cVytbu5aDeImYPKa8pGIMJDrGZ6PUWapgttWO1YNSWo=; b=Mytmju4/IUwUlmeHOODvqaraV3lGSyuGfVkNT5+KxFAW8AgkxhvRCaDlKkFwqvfB8O Z78PfwwUjDcEV74gARyWBynspGe6P3Lq2svhuy+eWBAswAjUb1KqcM0DKBNac2vgJCNh WSSrrNchxDRtY69bE8gOYxRq4pvHtFEpWMqwrWVd21FtYd6TGxpaaGvMSEpHjK0TShUv viEPS38w7bv1i8e72HszPDPgtped8ARUoJDRizpcRqj3iFhVPQFXtEQY0401omzQYWEd USa8emukyfRLBGupBmJtSBZQJ7HNfpfiXlvSZ/NOcWHm5yzpdkYiy2LWGz9w+B5UaUG7 NmmA== X-Gm-Message-State: APjAAAWM3+IBN8xosRSrayEEOL+olEmu7Rld3KeLP3vNK6BF5RFVL44F 3ghNwFu2LH+KoQbiz8DYkSMdVA== X-Google-Smtp-Source: APXvYqzVMF0R+kyeDNgLI4QVwcAzQuyJbImC6/3qU7I+I0w6fwpvAl/Ay1oUpkLuzSS/Uus7LaWquA== X-Received: by 2002:a1c:f607:: with SMTP id w7mr3358169wmc.84.1568197535579; Wed, 11 Sep 2019 03:25:35 -0700 (PDT) Received: from holly.lan (cpc141214-aztw34-2-0-cust773.18-1.cable.virginm.net. [86.9.19.6]) by smtp.gmail.com with ESMTPSA id e20sm2583505wme.3.2019.09.11.03.25.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Sep 2019 03:25:34 -0700 (PDT) Date: Wed, 11 Sep 2019 11:25:33 +0100 From: Daniel Thompson To: Andreas Kemnade Cc: lee.jones@linaro.org, jingoohan1@gmail.com, jacek.anaszewski@gmail.com, pavel@ucw.cz, dmurphy@ti.com, robh+dt@kernel.org, mark.rutland@arm.com, b.zolnierkie@samsung.com, dri-devel@lists.freedesktop.org, linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fbdev@vger.kernel.org, "H. Nikolaus Schaller" Subject: Re: [PATCH v2 2/2] backlight: lm3630a: add an enable gpio for the HWEN pin Message-ID: <20190911102533.not4ta3xwgm6bhjo@holly.lan> References: <20190910212909.18095-1-andreas@kemnade.info> <20190910212909.18095-3-andreas@kemnade.info> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190910212909.18095-3-andreas@kemnade.info> User-Agent: NeoMutt/20180716 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 10, 2019 at 11:29:09PM +0200, Andreas Kemnade wrote: > For now just enable it in the probe function to allow i2c > access. Disabling also means resetting the register values > to default and according to the datasheet does not give > power savings > > Tested on Kobo Clara HD. > > Signed-off-by: Andreas Kemnade > --- > changes in v2: > - simplification > - correct gpio direction initialisation > > drivers/video/backlight/lm3630a_bl.c | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/drivers/video/backlight/lm3630a_bl.c b/drivers/video/backlight/lm3630a_bl.c > index 8f84f3684f04..9d0639d4202d 100644 > --- a/drivers/video/backlight/lm3630a_bl.c > +++ b/drivers/video/backlight/lm3630a_bl.c > @@ -12,6 +12,8 @@ > #include > #include > #include > +#include > +#include Nitpicking... but I don't think linux/gpio.h is used anymore. > #include > #include > > @@ -48,6 +50,7 @@ struct lm3630a_chip { > struct lm3630a_platform_data *pdata; > struct backlight_device *bleda; > struct backlight_device *bledb; > + struct gpio_desc *enable_gpio; > struct regmap *regmap; > struct pwm_device *pwmd; > }; > @@ -535,6 +538,13 @@ static int lm3630a_probe(struct i2c_client *client, > } > pchip->pdata = pdata; > > + pchip->enable_gpio = devm_gpiod_get_optional(&client->dev, "enable", > + GPIOD_OUT_HIGH); > + if (IS_ERR(pchip->enable_gpio)) { > + rval = PTR_ERR(pchip->enable_gpio); > + return rval; > + } > + > /* chip initialize */ > rval = lm3630a_chip_init(pchip); > if (rval < 0) { > -- > 2.20.1 >