From: Michal Hocko <mhocko@kernel.org>
To: Yunsheng Lin <linyunsheng@huawei.com>
Cc: Greg KH <gregkh@linuxfoundation.org>,
rafael@kernel.org, linux-kernel@vger.kernel.org,
peterz@infradead.org, mingo@kernel.org, linuxarm@huawei.com
Subject: Re: [PATCH] driver core: ensure a device has valid node id in device_add()
Date: Wed, 11 Sep 2019 14:02:17 +0200 [thread overview]
Message-ID: <20190911120217.GR4023@dhcp22.suse.cz> (raw)
In-Reply-To: <97ad9ede-3a69-bd9e-e6c9-c2a893459565@huawei.com>
On Wed 11-09-19 19:41:44, Yunsheng Lin wrote:
> On 2019/9/11 19:03, Yunsheng Lin wrote:
> > On 2019/9/11 15:34, Michal Hocko wrote:
> >> On Wed 11-09-19 15:22:30, Yunsheng Lin wrote:
> >> [...]
> >>> It seems that there is no protection that prevent setting the node
> >>> of device to an invalid node.
> >>> And the kernel does have a few different check now:
> >>> 1) some does " < 0" check;
> >>> 2) some does "== NUMA_NO_NODE" check;
> >>> 3) some does ">= MAX_NUMNODES" check;
> >>> 4) some does "< 0 || >= MAX_NUMNODES || !node_online(node)" check.
> >>>
> >>> We need to be consistent about the checking, right?
> >>
> >> You can try and chase each of them and see what to do with them. I
> >> suspect they are a result of random attempts to fortify the code in many
> >> cases. Consistency is certainly good but spreading more checks all over
> >> the place just adds more cargo cult. Each check should be reasonably
> >> justified.
> >
> > Ok, Let me focus on making the node_to_cpumask_map() NUMA_NO_NODE aware
> > by only checking "node == NUMA_NO_NODE" first.
>
> Hi, Michal
> It that ok for me to add your name to "Suggested-by" tag, since I am
> going to quote some of your words on the commit log.
Sure, no problem. Thanks!
--
Michal Hocko
SUSE Labs
next prev parent reply other threads:[~2019-09-11 12:02 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-09 6:04 [PATCH] driver core: ensure a device has valid node id in device_add() Yunsheng Lin
2019-09-09 9:53 ` Greg KH
2019-09-10 6:43 ` Yunsheng Lin
2019-09-10 7:13 ` Michal Hocko
2019-09-10 9:31 ` Greg KH
2019-09-10 10:58 ` Yunsheng Lin
2019-09-10 11:04 ` Michal Hocko
2019-09-10 11:12 ` Greg KH
2019-09-10 12:47 ` Yunsheng Lin
2019-09-10 12:53 ` Michal Hocko
2019-09-11 5:33 ` Michal Hocko
2019-09-11 6:15 ` Yunsheng Lin
2019-09-11 6:49 ` Michal Hocko
2019-09-11 7:22 ` Yunsheng Lin
2019-09-11 7:34 ` Michal Hocko
2019-09-11 11:03 ` Yunsheng Lin
2019-09-11 11:41 ` Yunsheng Lin
2019-09-11 12:02 ` Michal Hocko [this message]
2019-09-23 15:09 ` Peter Zijlstra
2019-09-09 18:50 ` Michal Hocko
2019-09-10 7:08 ` Yunsheng Lin
2019-09-10 7:24 ` Michal Hocko
2019-09-10 10:40 ` Yunsheng Lin
2019-09-10 11:01 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190911120217.GR4023@dhcp22.suse.cz \
--to=mhocko@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=linyunsheng@huawei.com \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).