linux-next: Signed-off-by missing for commit in the arm tree

linux-next: Signed-off-by missing for commit in the arm tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 198 bytes --]

Hi all,

Commit

  2505b9ba9c37 ("ARM: 8904/1: skip nomap memblocks while finding the lowmem/highmem boundary")

is missing a Signed-off-by from its author.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Signed-off-by missing for commit in the arm tree

[Russell King - ARM Linux admin]

This is correctly signed off, but Mike didn't send the patch correctly.
It missed a From: line for the proper author, so the patch was committed
as if Mike had authored it, which he didn't.

On Wed, Sep 11, 2019 at 12:14:59AM +1000, Stephen Rothwell wrote:
> Hi all,
> 
> Commit
> 
>   2505b9ba9c37 ("ARM: 8904/1: skip nomap memblocks while finding the lowmem/highmem boundary")
> 
> is missing a Signed-off-by from its author.
> 
> -- 
> Cheers,
> Stephen Rothwell



-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up
According to speedtest.net: 11.9Mbps down 500kbps up

Re: linux-next: Signed-off-by missing for commit in the arm tree

[Mike Rapoport]

On Tue, Sep 10, 2019 at 03:21:28PM +0100, Russell King - ARM Linux admin wrote:
> This is correctly signed off, but Mike didn't send the patch correctly.
> It missed a From: line for the proper author, so the patch was committed
> as if Mike had authored it, which he didn't.

Sorry about that, haven't used the patch system for couple of years now.
Would you like me to resubmit the patch?
 
> On Wed, Sep 11, 2019 at 12:14:59AM +1000, Stephen Rothwell wrote:
> > Hi all,
> > 
> > Commit
> > 
> >   2505b9ba9c37 ("ARM: 8904/1: skip nomap memblocks while finding the lowmem/highmem boundary")
> > 
> > is missing a Signed-off-by from its author.
> > 
> > -- 
> > Cheers,
> > Stephen Rothwell
> 
> 
> 
> -- 
> RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
> FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up
> According to speedtest.net: 11.9Mbps down 500kbps up

-- 
Sincerely yours,
Mike.

Re: linux-next: Signed-off-by missing for commit in the arm tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 221 bytes --]

Hi Mike,

On Wed, 11 Sep 2019 15:21:07 +0100 Mike Rapoport <rppt@linux.ibm.com> wrote:
>
> Would you like me to resubmit the patch?

It looks like Russell has already fixed it up.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Signed-off-by missing for commit in the arm tree

[Russell King - ARM Linux admin]

On Wed, Sep 11, 2019 at 03:21:07PM +0100, Mike Rapoport wrote:
> On Tue, Sep 10, 2019 at 03:21:28PM +0100, Russell King - ARM Linux admin wrote:
> > This is correctly signed off, but Mike didn't send the patch correctly.
> > It missed a From: line for the proper author, so the patch was committed
> > as if Mike had authored it, which he didn't.
> 
> Sorry about that, haven't used the patch system for couple of years now.
> Would you like me to resubmit the patch?

No, I recommitted with the correct author.  The patch system takes
standard formatted patches (in the format you'd send to the mailing
lists, complete with the From: header in the first line of the
description, as if you're passing a patch along from someone else)
with the exception of the KernelVersion: header which needs to appear
somewhere before the patch (which can be either body or header.)

>  
> > On Wed, Sep 11, 2019 at 12:14:59AM +1000, Stephen Rothwell wrote:
> > > Hi all,
> > > 
> > > Commit
> > > 
> > >   2505b9ba9c37 ("ARM: 8904/1: skip nomap memblocks while finding the lowmem/highmem boundary")
> > > 
> > > is missing a Signed-off-by from its author.
> > > 
> > > -- 
> > > Cheers,
> > > Stephen Rothwell
> > 
> > 
> > 
> > -- 
> > RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
> > FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up
> > According to speedtest.net: 11.9Mbps down 500kbps up
> 
> -- 
> Sincerely yours,
> Mike.
> 
> 

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up
According to speedtest.net: 11.9Mbps down 500kbps up

linux-next: Signed-off-by missing for commit in the arm tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 186 bytes --]

Hi all,

Commit

  116375be0461 ("ARM: 8944/1: hw_breakpoint: Handle inexact watchpoint addresses")

is missing a Signed-off-by from its author.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Signed-off-by missing for commit in the arm tree

[Russell King - ARM Linux admin]

Hi,

Thanks Stephen, patch dropped.

It looks like Doug used his "m.disordat.com" address to submit the
patch through the web interface, and there was no From: in the patch
itself, so that was used as the patch author.  However, as you spotted,
it was signed off using Doug's "chromium.org" address.

I think it's time to make the patch system a bit more strict, checking
that the submission address is mentioned in a signed-off-by tag
somewhere in the commit message.

Doug, the patch system does have your "chromium.org" address, if that's
the one you want to use as the author, please submit using that instead.
Thanks.

Russell.

On Sun, Jan 19, 2020 at 12:18:48PM +1100, Stephen Rothwell wrote:
> Hi all,
> 
> Commit
> 
>   116375be0461 ("ARM: 8944/1: hw_breakpoint: Handle inexact watchpoint addresses")
> 
> is missing a Signed-off-by from its author.
> 
> -- 
> Cheers,
> Stephen Rothwell



-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up
According to speedtest.net: 11.9Mbps down 500kbps up

linux-next: Signed-off-by missing for commit in the arm tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 191 bytes --]

Hi all,

Commit

  aafc8eb78635 ("ARM: update __swp_entry_to_pte() to use PTE_TYPE_FAULT")

is missing a Signed-off-by from its author and committer.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Signed-off-by missing for commit in the arm tree

[Russell King (Oracle)]

On Fri, Jun 04, 2021 at 08:15:03AM +1000, Stephen Rothwell wrote:
> Hi all,
> 
> Commit
> 
>   aafc8eb78635 ("ARM: update __swp_entry_to_pte() to use PTE_TYPE_FAULT")
> 
> is missing a Signed-off-by from its author and committer.

For the record... as mentioned on irc, this looks perfectly fine to me:

commit aafc8eb78635a2ecb612653f57f1e86e9030b5d9
Author:     Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
AuthorDate: Thu May 13 11:53:17 2021 +0100
Commit:     Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
CommitDate: Thu Jun 3 11:39:02 2021 +0100
...
    Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>

It seems that the author and committer do indeed have the appropriate
sign-off in place on this commit.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!