From: Guenter Roeck <linux@roeck-us.net>
To: Loic Poulain <loic.poulain@linaro.org>
Cc: Jorge Ramirez-Ortiz <jorge.ramirez-ortiz@linaro.org>,
wim@linux-watchdog.org, linux-watchdog@vger.kernel.org,
linux-kernel@vger.kernel.org,
Bjorn Andersson <bjorn.andersson@linaro.org>
Subject: Re: [PATCH 1/2] watchdog: pm8916_wdt: fix pretimeout registration flow
Date: Wed, 11 Sep 2019 10:54:53 -0700 [thread overview]
Message-ID: <20190911175453.GA31612@roeck-us.net> (raw)
In-Reply-To: <CAMZdPi-P_AopbbyJEWDbnm7X8MtxTzs=MN13+UFndL2OK5VReg@mail.gmail.com>
On Wed, Sep 11, 2019 at 10:04:12AM +0200, Loic Poulain wrote:
> Hi Guenter, Jorge,
>
> On Mon, 9 Sep 2019 at 00:50, Guenter Roeck <linux@roeck-us.net> wrote:
>
> > On 9/6/19 1:30 PM, Jorge Ramirez-Ortiz wrote:
> > > When an IRQ is present in the dts, the probe function shall fail if
> > > the interrupt can not be registered.
> > >
> >
> > The author intended differently, and did not want registration to fail
> > in this situation, following the logic that it is better to have a
> > standard watchdog without pretimeout than no watchdog at all.
> >
>
> Indeed, but I tend to agree with this change since it aligns behavior with
> other
> watchdog drivers and I assume there is a serious issue if request_irq fails.
> I suggest adding a dev_err message in such case.
>
> Copying the author; I am not inclined to accept such a change without
> > input from the driver author.
> >
> > Similar, for the deferred probe, we'll need to know from the driver author
> > if this is a concern. In general it is, but there are cases where
> > -EPROBE_DEFFER is never returned in practice (eg for some SoC watchdog
> > drivers).
> >
>
> The IRQ controller is the SPMI bus parent node whose driver (MFD_SPMI_PMIC)
> is a direct dependency of pm8916_wdt. I'm not sure in which scenario this
> could
> happen.
>
Not sure what the action item is. Accept the patch as-is (Reviewed-by
appreciated), or resubmit without the -EPROBE_DEFER check ?
Thanks,
Guenter
next prev parent reply other threads:[~2019-09-11 17:54 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-06 20:30 [PATCH 1/2] watchdog: pm8916_wdt: fix pretimeout registration flow Jorge Ramirez-Ortiz
2019-09-06 20:30 ` [PATCH 2/2] watchdog: pm8916_wdt: fix missing include Jorge Ramirez-Ortiz
2019-09-08 22:54 ` Guenter Roeck
2019-09-08 22:50 ` [PATCH 1/2] watchdog: pm8916_wdt: fix pretimeout registration flow Guenter Roeck
[not found] ` <CAMZdPi-P_AopbbyJEWDbnm7X8MtxTzs=MN13+UFndL2OK5VReg@mail.gmail.com>
2019-09-11 17:54 ` Guenter Roeck [this message]
2019-09-13 10:36 ` Loic Poulain
2019-09-13 12:52 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190911175453.GA31612@roeck-us.net \
--to=linux@roeck-us.net \
--cc=bjorn.andersson@linaro.org \
--cc=jorge.ramirez-ortiz@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=loic.poulain@linaro.org \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).