From: Dan Carpenter <dan.carpenter@oracle.com>
To: Sandro Volery <sandro@volery.com>
Cc: valdis.kletnieks@vt.edu, gregkh@linuxfoundation.org,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
linux@rasmusvillemoes.dk
Subject: Re: [PATCH v4] Staging: exfat: avoid use of strcpy
Date: Wed, 11 Sep 2019 22:03:55 +0300 [thread overview]
Message-ID: <20190911190355.GA18977@kadam> (raw)
In-Reply-To: <20190911195303.GA27966@volery>
On Wed, Sep 11, 2019 at 09:53:03PM +0200, Sandro Volery wrote:
> diff --git a/drivers/staging/exfat/exfat_core.c b/drivers/staging/exfat/exfat_core.c
> index da8c58149c35..4336fee444ce 100644
> --- a/drivers/staging/exfat/exfat_core.c
> +++ b/drivers/staging/exfat/exfat_core.c
> @@ -2960,18 +2960,15 @@ s32 resolve_path(struct inode *inode, char *path, struct chain_t *p_dir,
> struct super_block *sb = inode->i_sb;
> struct fs_info_t *p_fs = &(EXFAT_SB(sb)->fs_info);
> struct file_id_t *fid = &(EXFAT_I(inode)->fid);
> -
> - if (strlen(path) >= (MAX_NAME_LENGTH * MAX_CHARSET_SIZE))
> +
You have added a tab here.
> + if (strscpy(name_buf, path, sizeof(name_buf)) < 0)
> return FFS_INVALIDPATH;
>
> - strcpy(name_buf, path);
> -
> nls_cstring_to_uniname(sb, p_uniname, name_buf, &lossy);
> if (lossy)
> return FFS_INVALIDPATH;
>
> - fid->size = i_size_read(inode);
> -
> +fid->size = i_size_read(inode);
And you accidentally deleted some white space here.
I use vim, so I have it configured to highlight whitespace at the end of
a line. I don't remember how it's done now but I googled it for you.
https://vim.fandom.com/wiki/Highlight_unwanted_spaces
regards,
dan carpenter
next prev parent reply other threads:[~2019-09-11 19:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-11 19:53 [PATCH v4] Staging: exfat: avoid use of strcpy Sandro Volery
2019-09-11 19:03 ` Dan Carpenter [this message]
2019-09-11 19:16 ` Sandro Volery
2019-09-11 19:22 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190911190355.GA18977@kadam \
--to=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=sandro@volery.com \
--cc=valdis.kletnieks@vt.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).