From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 68292C49ED9 for ; Thu, 12 Sep 2019 07:44:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3AFDE20830 for ; Thu, 12 Sep 2019 07:44:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729951AbfILHoG (ORCPT ); Thu, 12 Sep 2019 03:44:06 -0400 Received: from metis.ext.pengutronix.de ([85.220.165.71]:39347 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728927AbfILHoG (ORCPT ); Thu, 12 Sep 2019 03:44:06 -0400 Received: from pty.hi.pengutronix.de ([2001:67c:670:100:1d::c5]) by metis.ext.pengutronix.de with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1i8Jlr-0001qk-0T; Thu, 12 Sep 2019 09:44:03 +0200 Received: from ukl by pty.hi.pengutronix.de with local (Exim 4.89) (envelope-from ) id 1i8Jlh-00023h-Ee; Thu, 12 Sep 2019 09:43:53 +0200 Date: Thu, 12 Sep 2019 09:43:53 +0200 From: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= To: Joerg Roedel Cc: devicetree@vger.kernel.org, Frank Rowand , Robin Murphy , linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org, Rob Herring , linux-mediatek@lists.infradead.org, kernel@pengutronix.de, Matthias Brugger , Will Deacon , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v1 1/2] iommu: pass cell_count = -1 to of_for_each_phandle with cells_name Message-ID: <20190912074353.wqohpfydjxueqade@pengutronix.de> References: <20190824132846.8589-1-u.kleine-koenig@pengutronix.de> <20190903125210.GB11530@8bytes.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20190903125210.GB11530@8bytes.org> User-Agent: NeoMutt/20170113 (1.7.2) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c5 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 03, 2019 at 02:52:10PM +0200, Joerg Roedel wrote: > On Sat, Aug 24, 2019 at 03:28:45PM +0200, Uwe Kleine-König wrote: > > Currently of_for_each_phandle ignores the cell_count parameter when a > > cells_name is given. I intend to change that and let the iterator fall > > back to a non-negative cell_count if the cells_name property is missing > > in the referenced node. > > > > To not change how existing of_for_each_phandle's users iterate, fix them > > to pass cell_count = -1 when also cells_name is given which yields the > > expected behaviour with and without my change. > > > > Signed-off-by: Uwe Kleine-König > > --- > > drivers/iommu/arm-smmu.c | 2 +- > > drivers/iommu/mtk_iommu_v1.c | 2 +- > > 2 files changed, 2 insertions(+), 2 deletions(-) > > Acked-by: Joerg Roedel Does this ack mean that Rob is expected to apply this together with patch 2? Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | http://www.pengutronix.de/ |