linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] arm: dts: renesas: r8a77980: Remove r8a77970 DU compatible
@ 2019-09-12 10:37 Kieran Bingham
  2019-09-12 11:56 ` Geert Uytterhoeven
  2019-09-13  8:22 ` Simon Horman
  0 siblings, 2 replies; 5+ messages in thread
From: Kieran Bingham @ 2019-09-12 10:37 UTC (permalink / raw)
  To: linux-renesas-soc
  Cc: Sergei Shtylyov, Kieran Bingham, Simon Horman,
	Geert Uytterhoeven, Magnus Damm, Rob Herring, Mark Rutland,
	open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
	open list

The r8a77970 was added with an compatible string for a differnet device
rather than adding the correct compatible to the driver.

Remove the unnecessary compatible which is for a different platform.

Signed-off-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
---
Please note, this patch should not be integrated until the renesas,du-r8a77980
compatible string makes it into the DU [0].

[0] https://lore.kernel.org/linux-renesas-soc/a9cc2193-0a18-0490-c273-c64bd70992f5@ideasonboard.com/T/#t

 arch/arm64/boot/dts/renesas/r8a77980.dtsi | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/arch/arm64/boot/dts/renesas/r8a77980.dtsi b/arch/arm64/boot/dts/renesas/r8a77980.dtsi
index 042f4089e546..c6195377d181 100644
--- a/arch/arm64/boot/dts/renesas/r8a77980.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a77980.dtsi
@@ -1487,8 +1487,7 @@
 		};
 
 		du: display@feb00000 {
-			compatible = "renesas,du-r8a77980",
-				     "renesas,du-r8a77970";
+			compatible = "renesas,du-r8a77980";
 			reg = <0 0xfeb00000 0 0x80000>;
 			interrupts = <GIC_SPI 256 IRQ_TYPE_LEVEL_HIGH>;
 			clocks = <&cpg CPG_MOD 724>;
-- 
2.20.1


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] arm: dts: renesas: r8a77980: Remove r8a77970 DU compatible
  2019-09-12 10:37 [PATCH] arm: dts: renesas: r8a77980: Remove r8a77970 DU compatible Kieran Bingham
@ 2019-09-12 11:56 ` Geert Uytterhoeven
  2019-09-12 12:03   ` Kieran Bingham
  2019-09-13  8:22 ` Simon Horman
  1 sibling, 1 reply; 5+ messages in thread
From: Geert Uytterhoeven @ 2019-09-12 11:56 UTC (permalink / raw)
  To: Kieran Bingham
  Cc: Linux-Renesas, Sergei Shtylyov, Simon Horman, Geert Uytterhoeven,
	Magnus Damm, Rob Herring, Mark Rutland,
	open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
	open list

On Thu, Sep 12, 2019 at 12:38 PM Kieran Bingham
<kieran.bingham+renesas@ideasonboard.com> wrote:
> The r8a77970 was added with an compatible string for a differnet device

different

> rather than adding the correct compatible to the driver.
>
> Remove the unnecessary compatible which is for a different platform.
>
> Signed-off-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

> Please note, this patch should not be integrated until the renesas,du-r8a77980
> compatible string makes it into the DU [0].

Hence postponed.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] arm: dts: renesas: r8a77980: Remove r8a77970 DU compatible
  2019-09-12 11:56 ` Geert Uytterhoeven
@ 2019-09-12 12:03   ` Kieran Bingham
  2019-09-12 12:04     ` Geert Uytterhoeven
  0 siblings, 1 reply; 5+ messages in thread
From: Kieran Bingham @ 2019-09-12 12:03 UTC (permalink / raw)
  To: Geert Uytterhoeven
  Cc: Linux-Renesas, Sergei Shtylyov, Simon Horman, Geert Uytterhoeven,
	Magnus Damm, Rob Herring, Mark Rutland,
	open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
	open list

Hi Geert,

On 12/09/2019 12:56, Geert Uytterhoeven wrote:
> On Thu, Sep 12, 2019 at 12:38 PM Kieran Bingham
> <kieran.bingham+renesas@ideasonboard.com> wrote:
>> The r8a77970 was added with an compatible string for a differnet device
> 
> different

Also s/an/a/ ... Perhaps I should just step away from the keyboard
today, I can't seem to type ! hehe


>> rather than adding the correct compatible to the driver.
>>
>> Remove the unnecessary compatible which is for a different platform.
>>
>> Signed-off-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
> 
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> 
>> Please note, this patch should not be integrated until the renesas,du-r8a77980
>> compatible string makes it into the DU [0].
> 
> Hence postponed.


Thanks.
--
KB


> Gr{oetje,eeting}s,
> 
>                         Geert
> 


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] arm: dts: renesas: r8a77980: Remove r8a77970 DU compatible
  2019-09-12 12:03   ` Kieran Bingham
@ 2019-09-12 12:04     ` Geert Uytterhoeven
  0 siblings, 0 replies; 5+ messages in thread
From: Geert Uytterhoeven @ 2019-09-12 12:04 UTC (permalink / raw)
  To: Kieran Bingham
  Cc: Linux-Renesas, Sergei Shtylyov, Simon Horman, Geert Uytterhoeven,
	Magnus Damm, Rob Herring, Mark Rutland,
	open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
	open list

Hi Kieran,

On Thu, Sep 12, 2019 at 2:03 PM Kieran Bingham
<kieran.bingham+renesas@ideasonboard.com> wrote:
> On 12/09/2019 12:56, Geert Uytterhoeven wrote:
> > On Thu, Sep 12, 2019 at 12:38 PM Kieran Bingham
> > <kieran.bingham+renesas@ideasonboard.com> wrote:
> >> The r8a77970 was added with an compatible string for a differnet device
> >
> > different
>
> Also s/an/a/ ... Perhaps I should just step away from the keyboard
> today, I can't seem to type ! hehe

Doh, finding a first typo increased my adrenaline level, masking the ability
to see a second ;-)

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] arm: dts: renesas: r8a77980: Remove r8a77970 DU compatible
  2019-09-12 10:37 [PATCH] arm: dts: renesas: r8a77980: Remove r8a77970 DU compatible Kieran Bingham
  2019-09-12 11:56 ` Geert Uytterhoeven
@ 2019-09-13  8:22 ` Simon Horman
  1 sibling, 0 replies; 5+ messages in thread
From: Simon Horman @ 2019-09-13  8:22 UTC (permalink / raw)
  To: Kieran Bingham
  Cc: linux-renesas-soc, Sergei Shtylyov, Geert Uytterhoeven,
	Magnus Damm, Rob Herring, Mark Rutland,
	open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
	open list

On Thu, Sep 12, 2019 at 11:37:34AM +0100, Kieran Bingham wrote:
> The r8a77970 was added with an compatible string for a differnet device
> rather than adding the correct compatible to the driver.
> 
> Remove the unnecessary compatible which is for a different platform.
> 
> Signed-off-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>

Reviewed-by: Simon Horman <horms+renesas@verge.net.au>

> ---
> Please note, this patch should not be integrated until the renesas,du-r8a77980
> compatible string makes it into the DU [0].
> 
> [0] https://lore.kernel.org/linux-renesas-soc/a9cc2193-0a18-0490-c273-c64bd70992f5@ideasonboard.com/T/#t
> 
>  arch/arm64/boot/dts/renesas/r8a77980.dtsi | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/renesas/r8a77980.dtsi b/arch/arm64/boot/dts/renesas/r8a77980.dtsi
> index 042f4089e546..c6195377d181 100644
> --- a/arch/arm64/boot/dts/renesas/r8a77980.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a77980.dtsi
> @@ -1487,8 +1487,7 @@
>  		};
>  
>  		du: display@feb00000 {
> -			compatible = "renesas,du-r8a77980",
> -				     "renesas,du-r8a77970";
> +			compatible = "renesas,du-r8a77980";
>  			reg = <0 0xfeb00000 0 0x80000>;
>  			interrupts = <GIC_SPI 256 IRQ_TYPE_LEVEL_HIGH>;
>  			clocks = <&cpg CPG_MOD 724>;
> -- 
> 2.20.1
> 

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2019-09-13  8:22 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-12 10:37 [PATCH] arm: dts: renesas: r8a77980: Remove r8a77970 DU compatible Kieran Bingham
2019-09-12 11:56 ` Geert Uytterhoeven
2019-09-12 12:03   ` Kieran Bingham
2019-09-12 12:04     ` Geert Uytterhoeven
2019-09-13  8:22 ` Simon Horman

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).