From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Heiko Schocher <hs@denx.de>
Cc: linux-serial@vger.kernel.org,
Alexander Sverdlin <alexander.sverdlin@nokia.com>,
Darwin Dingel <darwin.dingel@alliedtelesis.co.nz>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jslaby@suse.com>, John Garry <john.garry@huawei.com>,
Linus Walleij <linus.walleij@linaro.org>,
Lubomir Rintel <lkundrak@v3.sk>, Rob Herring <robh@kernel.org>,
Thierry Reding <treding@nvidia.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] tty: 8250_of: Use software emulated RS485 direction control
Date: Fri, 13 Sep 2019 13:24:09 +0300 [thread overview]
Message-ID: <20190913102409.GF2680@smile.fi.intel.com> (raw)
In-Reply-To: <20190913050105.1132080-1-hs@denx.de>
On Fri, Sep 13, 2019 at 07:01:05AM +0200, Heiko Schocher wrote:
> Use software emulated RS485 direction control to provide RS485 API
>
> Currently it is not possible to use rs485 as pointer to
> rs485_config struct in struct uart_port is NULL in case we
> configure the port through device tree.
Thank you for the patch, few recommendations for the future submissions.
> Patch is based on:
> git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> commit:
> 505a8ec7e11a - Revert "drm/i915/userptr: Acquire the page lock around set_page_dirty()"
More reliably is to base on corresponding subsystem tree, i.e. tty-next for
this case.
> checkpatch output:
> $ ./scripts/checkpatch.pl 0001-tty-8250_of-Use-software-emulated-RS485-direction-co.patch
> total: 0 errors, 0 warnings, 43 lines checked
>
> 0001-tty-8250_of-Use-software-emulated-RS485-direction-co.patch has no obvious style problems and is ready for submission.
There is no need to mention this. It's supposed that submitter did that
themselves.
When you gather people to send the patch to, I recommend to use some threshold,
e.g. `scripts/get_maintainer.pl --git --git-min-percent=67 ...`
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2019-09-13 10:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-13 5:01 [PATCH] tty: 8250_of: Use software emulated RS485 direction control Heiko Schocher
2019-09-13 10:24 ` Andy Shevchenko [this message]
2019-09-13 14:51 ` Heiko Schocher
2019-09-13 15:05 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190913102409.GF2680@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=alexander.sverdlin@nokia.com \
--cc=darwin.dingel@alliedtelesis.co.nz \
--cc=gregkh@linuxfoundation.org \
--cc=hs@denx.de \
--cc=john.garry@huawei.com \
--cc=jslaby@suse.com \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=lkundrak@v3.sk \
--cc=robh@kernel.org \
--cc=treding@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).