From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E9219C49ED7 for ; Fri, 13 Sep 2019 13:29:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B1AD620640 for ; Fri, 13 Sep 2019 13:29:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1568381373; bh=+HLiC11vGqxHSXKdFpYDJRMhz3DLeHPkz4fOm8VWOuc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=GhT3/tXSaZrJiREywGlF7PVJEh6xvvyI3zl+4LO4j3mUeb5mlL4c+IMEucQ+elirJ oveYbHrEaZQqGfM4gW/ZXc8DQccwx0ui1tuDrenN0HRd2/bAvjtb7wiBR8IseWdhcV i/uyZK6cIPH0Ya+Rxt+Ut2Sz2FM7bCcKfOdc8+U0= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2391654AbfIMN3d (ORCPT ); Fri, 13 Sep 2019 09:29:33 -0400 Received: from mail.kernel.org ([198.145.29.99]:47208 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390390AbfIMNTO (ORCPT ); Fri, 13 Sep 2019 09:19:14 -0400 Received: from localhost (unknown [104.132.45.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id DE45F20640; Fri, 13 Sep 2019 13:19:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1568380753; bh=+HLiC11vGqxHSXKdFpYDJRMhz3DLeHPkz4fOm8VWOuc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=hNW2KzMruo4eaKmDpri9ZyrSMUrlDW6AUVRx4t0vAUYJ5cX9QbPi6QkNHD/KKmcNx hqMO43PGRsKu7JiYTvdqInR6abFG9sHyjTnf9HYiFESRH/TEJ3/ji3WQzrGKqaw4B+ uRM1Uy2gU2AR+72dNYeid0gmnmL7/EYtIBCKzDgQ= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Roman Bolshakov , Bart Van Assche , "Martin K. Petersen" , Sasha Levin Subject: [PATCH 4.19 146/190] scsi: target/iblock: Fix overrun in WRITE SAME emulation Date: Fri, 13 Sep 2019 14:06:41 +0100 Message-Id: <20190913130611.632934574@linuxfoundation.org> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20190913130559.669563815@linuxfoundation.org> References: <20190913130559.669563815@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org [ Upstream commit 5676234f20fef02f6ca9bd66c63a8860fce62645 ] WRITE SAME corrupts data on the block device behind iblock if the command is emulated. The emulation code issues (M - 1) * N times more bios than requested, where M is the number of 512 blocks per real block size and N is the NUMBER OF LOGICAL BLOCKS specified in WRITE SAME command. So, for a device with 4k blocks, 7 * N more LBAs gets written after the requested range. The issue happens because the number of 512 byte sectors to be written is decreased one by one while the real bios are typically from 1 to 8 512 byte sectors per bio. Fixes: c66ac9db8d4a ("[SCSI] target: Add LIO target core v4.0.0-rc6") Cc: Signed-off-by: Roman Bolshakov Reviewed-by: Bart Van Assche Signed-off-by: Martin K. Petersen Signed-off-by: Sasha Levin --- drivers/target/target_core_iblock.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/target/target_core_iblock.c b/drivers/target/target_core_iblock.c index 1bc9b14236d8b..854b2bcca7c1a 100644 --- a/drivers/target/target_core_iblock.c +++ b/drivers/target/target_core_iblock.c @@ -515,7 +515,7 @@ iblock_execute_write_same(struct se_cmd *cmd) /* Always in 512 byte units for Linux/Block */ block_lba += sg->length >> SECTOR_SHIFT; - sectors -= 1; + sectors -= sg->length >> SECTOR_SHIFT; } iblock_submit_bios(&list); -- 2.20.1