From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A2D0AC49ED7 for ; Fri, 13 Sep 2019 13:38:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 76A24206BB for ; Fri, 13 Sep 2019 13:38:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="otIhPvmT"; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="dFp1w25Q" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389277AbfIMNi1 (ORCPT ); Fri, 13 Sep 2019 09:38:27 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:57298 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387584AbfIMNi1 (ORCPT ); Fri, 13 Sep 2019 09:38:27 -0400 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 187CC601C3; Fri, 13 Sep 2019 13:38:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1568381906; bh=8zCYlualNWwt8I4c0YzwmA3bS57xaqFYOUXdN0Z2JY8=; h=Subject:From:In-Reply-To:References:To:Cc:Date:From; b=otIhPvmT/CkIKYRegdd5jQHFa6MtrIpYXst0vtL8caJ8tl2GNAfl6UGWrI5blJOqi SMogT/zqPxH97TaYUD6HuRVi0Kld9ih52VqOCTex2abccfbjQggj/Nw00NAY/mhEgF vIhaWud1ZvfUhceWonA9DA1JJ8vSaOSxbfkCRSRY= Received: from potku.adurom.net (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 3D3546013C; Fri, 13 Sep 2019 13:38:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1568381905; bh=8zCYlualNWwt8I4c0YzwmA3bS57xaqFYOUXdN0Z2JY8=; h=Subject:From:In-Reply-To:References:To:Cc:From; b=dFp1w25QSplRRswg7lguMThAJPTGvpfoErkH/2cdLU83vXGNRW6/kd2aLzeBKwjSQ FlC/Fz7GBQYn4RMC/70HGlds8kg5KrY8FKqw8oaFd52wGDiguiSLoNWjCK1m4+Vsp8 wPJQ85BX4TPmOtjTnPoxRFUNSktauNwAVZiuuyXE= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 3D3546013C Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH 3/3] libertas: Remove unneeded variable and make function to be void From: Kalle Valo In-Reply-To: <1568306492-42998-4-git-send-email-zhongjiang@huawei.com> References: <1568306492-42998-4-git-send-email-zhongjiang@huawei.com> To: zhong jiang Cc: , , , , User-Agent: pwcli/0.0.0-git (https://github.com/kvalo/pwcli/) Python/2.7.12 Message-Id: <20190913133826.187CC601C3@smtp.codeaurora.org> Date: Fri, 13 Sep 2019 13:38:26 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org zhong jiang wrote: > lbs_process_event do not need return value to cope with different > cases. And change functon return type to void. > > Signed-off-by: zhong jiang Same here, I just don't see the benefit. Patch set to Rejected. -- https://patchwork.kernel.org/patch/11143397/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches