From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 338F8C49ED7 for ; Fri, 13 Sep 2019 22:36:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id EF741206A5 for ; Fri, 13 Sep 2019 22:36:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="FQ8lqume" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2404141AbfIMWgs (ORCPT ); Fri, 13 Sep 2019 18:36:48 -0400 Received: from mail-lj1-f195.google.com ([209.85.208.195]:45887 "EHLO mail-lj1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2404041AbfIMWgr (ORCPT ); Fri, 13 Sep 2019 18:36:47 -0400 Received: by mail-lj1-f195.google.com with SMTP id q64so18021880ljb.12 for ; Fri, 13 Sep 2019 15:36:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:mail-followup-to:references :mime-version:content-disposition:in-reply-to:user-agent; bh=sfVAv/G3SBA3hh8aRouxiJvEsUEGrIoANWZewhhUKls=; b=FQ8lqumewVJJLLoIRzb4SA4o96HlDROwFkRGtgVHua5RS/MK5DpYJr00VqfhPh6TOf n5SLEArHZ1ROJSNVTVvnalcmOJEnMqVTs9GltJ0c6ptleHrINEMuFXthzCJEdmxzHII+ Z7vAIrDlnxCHnaJY4m4dYap1Yr4h9jQDump0hM+7NEFEW1R3ot4T7MFye3msGIX2YwZ9 RzB7ob3kAbMvetVCIG42gD0e+UvbFT8peiWoADClBsFWHPOK0GdPZbrjup1ajrpBwPRD VsBRsXRPDMT1jK68FtBAeQb8wq3XikY429TzBmL5qlK5tY6gKVXXi7KBJwu7wrkICxCr s5HQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-disposition :in-reply-to:user-agent; bh=sfVAv/G3SBA3hh8aRouxiJvEsUEGrIoANWZewhhUKls=; b=lx2t552FPWt4FjmA3JfAY/rw4kbF9cWKI2vLoMi2mmBoTvnkE2cYCQEkaJErvjAmQw m4eN54FsRUnwOD5E/TqDwPdeGGENVPqVrZq0Slr33Yycht9u1PGdrALLVSNTZrLb+9AA 2iV8ZS03fQspcYsnpGkXj9IX45pyD3H9BLsIbvAUBo46HQyPZQSZmdfQWN5QwqtQX/RN SuKl/2jifv1W7DqreuHc0REqLxOOqC/8Sl342hznPB0cXlIwWfgC77xVqGkzOpoj2nDD /hCyLR5MINja68TBrtQLz8FnFgbpONUz0LZEFTX8927voaRpvQh1J0p7ubVFPaKDgdrq bEtw== X-Gm-Message-State: APjAAAUNjOncXQYVibv0ZqppTpw2V7uDFHw211LXLmumPIsB0f1rzqNW kYnsrrFcjRLvm2uh8TOxfvtg3w== X-Google-Smtp-Source: APXvYqwjlDzQxVv+WSKyHAC63FoEdn9FGOKDWAq3hjINghZA/hdEqL0Y2fOu/7VUIRcnkCROURpIaA== X-Received: by 2002:a2e:9081:: with SMTP id l1mr12064327ljg.33.1568414205743; Fri, 13 Sep 2019 15:36:45 -0700 (PDT) Received: from khorivan (168-200-94-178.pool.ukrtel.net. [178.94.200.168]) by smtp.gmail.com with ESMTPSA id h25sm8508971lfj.81.2019.09.13.15.36.44 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 13 Sep 2019 15:36:45 -0700 (PDT) Date: Sat, 14 Sep 2019 01:36:43 +0300 From: Ivan Khoronzhuk To: Yonghong Song Cc: "ast@kernel.org" , "daniel@iogearbox.net" , "davem@davemloft.net" , "jakub.kicinski@netronome.com" , "hawk@kernel.org" , "john.fastabend@gmail.com" , "linux-kernel@vger.kernel.org" , "netdev@vger.kernel.org" , "bpf@vger.kernel.org" , "clang-built-linux@googlegroups.com" Subject: Re: [PATCH bpf-next 11/11] samples: bpf: makefile: add sysroot support Message-ID: <20190913223642.GG26724@khorivan> Mail-Followup-To: Yonghong Song , "ast@kernel.org" , "daniel@iogearbox.net" , "davem@davemloft.net" , "jakub.kicinski@netronome.com" , "hawk@kernel.org" , "john.fastabend@gmail.com" , "linux-kernel@vger.kernel.org" , "netdev@vger.kernel.org" , "bpf@vger.kernel.org" , "clang-built-linux@googlegroups.com" References: <20190910103830.20794-1-ivan.khoronzhuk@linaro.org> <20190910103830.20794-12-ivan.khoronzhuk@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Sep 13, 2019 at 09:45:31PM +0000, Yonghong Song wrote: > > >On 9/10/19 11:38 AM, Ivan Khoronzhuk wrote: >> Basically it only enables that was added by previous couple fixes. >> For sure, just make tools/include to be included after sysroot >> headers. >> >> export ARCH=arm >> export CROSS_COMPILE=arm-linux-gnueabihf- >> make samples/bpf/ SYSROOT="path/to/sysroot" >> >> Sysroot contains correct libs installed and its headers ofc. >> Useful when working with NFC or virtual machine. >> >> Signed-off-by: Ivan Khoronzhuk >> --- >> samples/bpf/Makefile | 5 +++++ >> samples/bpf/README.rst | 10 ++++++++++ >> 2 files changed, 15 insertions(+) >> >> diff --git a/samples/bpf/Makefile b/samples/bpf/Makefile >> index 4edc5232cfc1..68ba78d1dbbe 100644 >> --- a/samples/bpf/Makefile >> +++ b/samples/bpf/Makefile >> @@ -177,6 +177,11 @@ ifeq ($(ARCH), arm) >> CLANG_EXTRA_CFLAGS := $(D_OPTIONS) >> endif >> >> +ifdef SYSROOT >> +ccflags-y += --sysroot=${SYSROOT} >> +PROGS_LDFLAGS := -L${SYSROOT}/usr/lib >> +endif >> + >> ccflags-y += -I$(objtree)/usr/include >> ccflags-y += -I$(srctree)/tools/lib/bpf/ >> ccflags-y += -I$(srctree)/tools/testing/selftests/bpf/ >> diff --git a/samples/bpf/README.rst b/samples/bpf/README.rst >> index 5f27e4faca50..786d0ab98e8a 100644 >> --- a/samples/bpf/README.rst >> +++ b/samples/bpf/README.rst >> @@ -74,3 +74,13 @@ samples for the cross target. >> export ARCH=arm64 >> export CROSS_COMPILE="aarch64-linux-gnu-" >> make samples/bpf/ LLC=~/git/llvm/build/bin/llc CLANG=~/git/llvm/build/bin/clang >> + >> +If need to use environment of target board (headers and libs), the SYSROOT >> +also can be set, pointing on FS of target board: >> + >> +export ARCH=arm64 >> +export CROSS_COMPILE="aarch64-linux-gnu-" >> +make samples/bpf/ SYSROOT=~/some_sdk/linux-devkit/sysroots/aarch64-linux-gnu >> + >> +Setting LLC and CLANG is not necessarily if it's installed on HOST and have >> +in its targets appropriate arch triple (usually it has several arches). > >You have very good description about how to build and test in cover >letter. Could you include those instructions here as well? This will >help keep a record so later people can try/test if needed. I will try. Thanks!!! -- Regards, Ivan Khoronzhuk