From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EEA48C4CEC9 for ; Sat, 14 Sep 2019 13:05:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C76DD2084F for ; Sat, 14 Sep 2019 13:05:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1568466344; bh=gU4CO6duH0AH0YKj1jI15GcCTMmQHOV1AnE0wHF0lbE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=zPK9GEvguzpgQqCh5f63rz8eRd+XnQdrONAoU3FFix0fw8uxBUQlXyhdcU5cLP4+Q BgWINiY5Ie2XuvOfTUQqv+9yscR404zqKALlJmfQlTzGOiWQMF8zHnBjF9ypKxWnJ7 AtjcqPyjwIAqFXcXAIwv5shrUmgNv4kiRW2Akh5s= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388709AbfINNFo (ORCPT ); Sat, 14 Sep 2019 09:05:44 -0400 Received: from mail.kernel.org ([198.145.29.99]:57318 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388575AbfINNFn (ORCPT ); Sat, 14 Sep 2019 09:05:43 -0400 Received: from earth.universe (unknown [185.62.205.105]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id A4DB2206A4; Sat, 14 Sep 2019 13:05:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1568466342; bh=gU4CO6duH0AH0YKj1jI15GcCTMmQHOV1AnE0wHF0lbE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=lsxJAW04dWcvUE0tzwucaUjD5aoqdG4PqgTbESOsIaaQBBk7k6373iozOifsrjsVL heLPLCjCzXjXa270ZhP+OP+6LGJZ2Nq6F95cBNHU3uA2IrtzjLPvKHfdysEM+HMcGM YPLyJ2AmpSCohiG7Ft7g0A95DppKBJ/mYJXuTEs8= Received: by earth.universe (Postfix, from userid 1000) id 3C6603C0CA2; Sat, 14 Sep 2019 15:05:40 +0200 (CEST) Date: Sat, 14 Sep 2019 15:05:40 +0200 From: Sebastian Reichel To: Tony Lindgren Cc: Matt Mackall , Herbert Xu , linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, linux-crypto@vger.kernel.org, Aaro Koskinen , Adam Ford , Pali =?utf-8?B?Um9ow6Fy?= , Rob Herring , Tero Kristo , devicetree@vger.kernel.org Subject: Re: [PATCH 0/6] Non-urgent fixes and improvments for omap3-rom-rng Message-ID: <20190914130540.jvtxaame7pat7jph@earth.universe> References: <20190913220922.29501-1-tony@atomide.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="mdog2bpqvzul6dqe" Content-Disposition: inline In-Reply-To: <20190913220922.29501-1-tony@atomide.com> User-Agent: NeoMutt/20180716 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --mdog2bpqvzul6dqe Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, On Fri, Sep 13, 2019 at 03:09:16PM -0700, Tony Lindgren wrote: > Here are fixes and improvments for omap3-rom-rng that's been broken for > a while. >=20 > The first four patches get it working, and then the last two patches add > support for runtime PM. Nice cleanups, the series is Reviewed-by: Sebastian Reichel Assuming you use clk_prepare_enable() in the runtime PM handler, I suggest to add another patch and go all the way to managed resources: devm_add_action() can be used for disabling runtime PM and devm_hwrng_register() can be used to register the hwrng device. -- Sebastian --mdog2bpqvzul6dqe Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEE72YNB0Y/i3JqeVQT2O7X88g7+poFAl185ZkACgkQ2O7X88g7 +ppqNA/+JmsrHxkgYD+ip05tbafR/Z7vXD250VZkgq+1vhiP5xn3FfwHTGHmNB02 WSnGZFh1i5i1XleRfA/2ITvoaqT3EhCx89DZPqrg1GYiUR/Ol3HhIh8axTOs331G KIFbTI3ZGH3pVqS7N77Egf4vGqmv/rUUnMZjm8b6flGVpLL4WvqPpGvs8Yglxdmq j+EntLH/jD+vm1MdaTgTLL7DchwgCW0uonukbfMKZqan8p7S9akqhvxmIo+G9OdV Ok19HmlUf/Mplg959p6HjaE0ycZ/6j2r7PZQrnYlzIyt6jyvbusIZPawOW7LSkWE 0TU6c00OHJwDN0dM5oL23AZM9I3kR5HF4Dd9Cfk1VaWnFpEumOrP1sjp0Czb2ZgL bVtlqfkhu+LDF052Sb544DbYICaRj6OB4LICDM6IEkPiwLgquK2vu0BmAIXmUMNV wEmQW+u2fIqDxUez15RSpgnToI35NFXj8XotFdyDtMpuNqM6hsV6wadMEE/j83l/ 8BJ0+RR4ftudQWdFTDDmyPPnbADAnRLjb4RF1HJWd94u1PrX88q5CHag1gPE+Jq+ XpUIZDjezBO9srd3UWteMBFGdpKTdxMQsfhxav/a11vMe+RAXcyKzzGg6rvCSx+X YMnq5CJdagSR1nmSFEJuv3lENUgBXxniwRX7EFbxsOE46kV2IXc= =lttE -----END PGP SIGNATURE----- --mdog2bpqvzul6dqe--