From: Andrew Lunn <andrew@lunn.ch>
To: Alexandru Ardelean <alexandru.ardelean@analog.com>
Cc: netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, davem@davemloft.net,
robh+dt@kernel.org, mark.rutland@arm.com, f.fainelli@gmail.com,
hkallweit1@gmail.com, mkubecek@suse.cz
Subject: Re: [PATCH v4 2/2] net: phy: adin: implement Energy Detect Powerdown mode via phy-tunable
Date: Sat, 14 Sep 2019 17:29:31 +0200 [thread overview]
Message-ID: <20190914152931.GK27922@lunn.ch> (raw)
In-Reply-To: <20190912162812.402-3-alexandru.ardelean@analog.com>
On Thu, Sep 12, 2019 at 07:28:12PM +0300, Alexandru Ardelean wrote:
> +static int adin_set_edpd(struct phy_device *phydev, u16 tx_interval)
> +{
> + u16 val;
> +
> + if (tx_interval == ETHTOOL_PHY_EDPD_DISABLE)
> + return phy_clear_bits(phydev, ADIN1300_PHY_CTRL_STATUS2,
> + (ADIN1300_NRG_PD_EN | ADIN1300_NRG_PD_TX_EN));
> +
> + val = ADIN1300_NRG_PD_EN;
> +
> + switch (tx_interval) {
> + case 1000: /* 1 second */
> + /* fallthrough */
> + case ETHTOOL_PHY_EDPD_DFLT_TX_MSECS:
> + val |= ADIN1300_NRG_PD_TX_EN;
> + /* fallthrough */
> + case ETHTOOL_PHY_EDPD_NO_TX:
> + break;
> + default:
> + return -EINVAL;
> + }
> +
> + return phy_modify(phydev, ADIN1300_PHY_CTRL_STATUS2,
> + (ADIN1300_NRG_PD_EN | ADIN1300_NRG_PD_TX_EN),
> + val);
> +}
> +
>
> + rc = adin_set_edpd(phydev, 1);
> + if (rc < 0)
> + return rc;
Hi Alexandru
Shouldn't this be adin_set_edpd(phydev, 1000);
Andrew
next prev parent reply other threads:[~2019-09-14 15:29 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-12 16:28 [PATCH v4 0/2] ethtool: implement Energy Detect Powerdown support via phy-tunable Alexandru Ardelean
2019-09-12 16:28 ` [PATCH v4 1/2] " Alexandru Ardelean
2019-09-14 15:26 ` Andrew Lunn
2019-09-15 15:08 ` Florian Fainelli
2019-09-12 16:28 ` [PATCH v4 2/2] net: phy: adin: implement Energy Detect Powerdown mode " Alexandru Ardelean
2019-09-14 15:29 ` Andrew Lunn [this message]
2019-09-15 15:11 ` Florian Fainelli
2019-09-16 6:44 ` Ardelean, Alexandru
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190914152931.GK27922@lunn.ch \
--to=andrew@lunn.ch \
--cc=alexandru.ardelean@analog.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mkubecek@suse.cz \
--cc=netdev@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).