From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 58F29C4CEC7 for ; Sun, 15 Sep 2019 07:07:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2371420873 for ; Sun, 15 Sep 2019 07:07:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727274AbfIOHHn (ORCPT ); Sun, 15 Sep 2019 03:07:43 -0400 Received: from wtarreau.pck.nerim.net ([62.212.114.60]:45095 "EHLO 1wt.eu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725497AbfIOHHn (ORCPT ); Sun, 15 Sep 2019 03:07:43 -0400 Received: (from willy@localhost) by pcw.home.local (8.15.2/8.15.2/Submit) id x8F77MEU021637; Sun, 15 Sep 2019 09:07:22 +0200 Date: Sun, 15 Sep 2019 09:07:22 +0200 From: Willy Tarreau To: Lennart Poettering Cc: Linus Torvalds , "Alexander E. Patrakov" , "Ahmed S. Darwish" , "Theodore Y. Ts'o" , Andreas Dilger , Jan Kara , Ray Strode , William Jon McCann , zhangjs , linux-ext4@vger.kernel.org, lkml Subject: Re: Linux 5.3-rc8 Message-ID: <20190915070722.GD20811@1wt.eu> References: <20190912034421.GA2085@darwi-home-pc> <20190912082530.GA27365@mit.edu> <20190914150206.GA2270@darwi-home-pc> <214fed0e-6659-def9-b5f8-a9d7a8cb72af@gmail.com> <20190915065655.GB29681@gardel-login> <20190915070103.GC20811@1wt.eu> <20190915070541.GC29681@gardel-login> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190915070541.GC29681@gardel-login> User-Agent: Mutt/1.6.1 (2016-04-27) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Sep 15, 2019 at 09:05:41AM +0200, Lennart Poettering wrote: > On So, 15.09.19 09:01, Willy Tarreau (w@1wt.eu) wrote: > > > On Sun, Sep 15, 2019 at 08:56:55AM +0200, Lennart Poettering wrote: > > > There's benefit in being able to wait until the pool is initialized > > > before we update the random seed stored on disk with a new one, > > > > And what exactly makes you think that waiting with arms crossed not > > doing anything else has any chance to make the situation change if > > you already had no such entropy available when reaching that first > > call, especially during early boot ? > > That code can finish 5h after boot, it's entirely fine with this > specific usecase. > > Again: we don't delay "the boot" for this. We just delay "writing a > new seed to disk" for this. And if that is 5h later, then that's > totally fine, because in the meantime it's just one bg process more that > hangs around waiting to do what it needs to do. Didn't you say it could also happen when using encrypted swap ? If so I suspect this could happen very early during boot, before any services may be started ? Willy