* [PATCH v2 2/3] iio: accel: adxl372: Fix push to buffers lost samples
@ 2019-09-10 14:44 Stefan Popa
2019-09-15 13:29 ` Jonathan Cameron
0 siblings, 1 reply; 2+ messages in thread
From: Stefan Popa @ 2019-09-10 14:44 UTC (permalink / raw)
To: jic23
Cc: Michael.Hennerich, knaack.h, lars, pmeerw, linux-kernel,
linux-iio, stefan.popa
One in two sample sets was lost by multiplying fifo_set_size with
sizeof(u16). Also, the double number of available samples were pushed to
the iio buffers.
Signed-off-by: Stefan Popa <stefan.popa@analog.com>
---
Changes in v2:
- Nothing changed.
drivers/iio/accel/adxl372.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/iio/accel/adxl372.c b/drivers/iio/accel/adxl372.c
index 7de5e1b..33edca8 100644
--- a/drivers/iio/accel/adxl372.c
+++ b/drivers/iio/accel/adxl372.c
@@ -553,8 +553,7 @@ static irqreturn_t adxl372_trigger_handler(int irq, void *p)
goto err;
/* Each sample is 2 bytes */
- for (i = 0; i < fifo_entries * sizeof(u16);
- i += st->fifo_set_size * sizeof(u16))
+ for (i = 0; i < fifo_entries; i += st->fifo_set_size)
iio_push_to_buffers(indio_dev, &st->fifo_buf[i]);
}
err:
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2 2/3] iio: accel: adxl372: Fix push to buffers lost samples
2019-09-10 14:44 [PATCH v2 2/3] iio: accel: adxl372: Fix push to buffers lost samples Stefan Popa
@ 2019-09-15 13:29 ` Jonathan Cameron
0 siblings, 0 replies; 2+ messages in thread
From: Jonathan Cameron @ 2019-09-15 13:29 UTC (permalink / raw)
To: Stefan Popa
Cc: Michael.Hennerich, knaack.h, lars, pmeerw, linux-kernel, linux-iio
On Tue, 10 Sep 2019 17:44:21 +0300
Stefan Popa <stefan.popa@analog.com> wrote:
> One in two sample sets was lost by multiplying fifo_set_size with
> sizeof(u16). Also, the double number of available samples were pushed to
> the iio buffers.
>
> Signed-off-by: Stefan Popa <stefan.popa@analog.com>
Applied with same fixes tag as previous and cc stable.
> ---
> Changes in v2:
> - Nothing changed.
>
> drivers/iio/accel/adxl372.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/iio/accel/adxl372.c b/drivers/iio/accel/adxl372.c
> index 7de5e1b..33edca8 100644
> --- a/drivers/iio/accel/adxl372.c
> +++ b/drivers/iio/accel/adxl372.c
> @@ -553,8 +553,7 @@ static irqreturn_t adxl372_trigger_handler(int irq, void *p)
> goto err;
>
> /* Each sample is 2 bytes */
> - for (i = 0; i < fifo_entries * sizeof(u16);
> - i += st->fifo_set_size * sizeof(u16))
> + for (i = 0; i < fifo_entries; i += st->fifo_set_size)
> iio_push_to_buffers(indio_dev, &st->fifo_buf[i]);
> }
> err:
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-09-15 13:30 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-10 14:44 [PATCH v2 2/3] iio: accel: adxl372: Fix push to buffers lost samples Stefan Popa
2019-09-15 13:29 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).