From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AE0E4C49ED7 for ; Mon, 16 Sep 2019 07:12:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7FC522067D for ; Mon, 16 Sep 2019 07:12:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730272AbfIPHMZ (ORCPT ); Mon, 16 Sep 2019 03:12:25 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:44370 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726024AbfIPHMZ (ORCPT ); Mon, 16 Sep 2019 03:12:25 -0400 Received: from localhost (unknown [85.119.46.8]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id D26FE1517258D; Mon, 16 Sep 2019 00:12:22 -0700 (PDT) Date: Mon, 16 Sep 2019 09:12:20 +0200 (CEST) Message-Id: <20190916.091220.1015956756124841222.davem@davemloft.net> To: Jose.Abreu@synopsys.com Cc: netdev@vger.kernel.org, Joao.Pinto@synopsys.com, peppe.cavallaro@st.com, alexandre.torgue@st.com, mcoquelin.stm32@gmail.com, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, christophe.roullier@st.com Subject: Re: [PATCH net] net: stmmac: Hold rtnl lock in suspend/resume callbacks From: David Miller In-Reply-To: <66b6c1395e4bbc836e80083b89b2189ce7382d7b.1568360548.git.joabreu@synopsys.com> References: <66b6c1395e4bbc836e80083b89b2189ce7382d7b.1568360548.git.joabreu@synopsys.com> X-Mailer: Mew version 6.8 on Emacs 26.2 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 16 Sep 2019 00:12:25 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Jose Abreu Date: Fri, 13 Sep 2019 11:50:32 +0200 > We need to hold rnl lock in suspend and resume callbacks because phylink > requires it. Otherwise we will get a WARN() in suspend and resume. > > Also, move phylink start and stop callbacks to inside device's internal > lock so that we prevent concurrent HW accesses. > > Fixes: 74371272f97f ("net: stmmac: Convert to phylink and remove phylib logic") > Reported-by: Christophe ROULLIER > Tested-by: Christophe ROULLIER > Signed-off-by: Jose Abreu Applied and queued up for v5.3 -stable. Thanks.