From: Mike Rapoport <rppt@kernel.org>
To: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Cc: Paul Burton <paul.burton@mips.com>,
linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org,
Mike Rapoport <rppt@linux.ibm.com>
Subject: Re: [PATCH] mips: sgi-ip27: switch from DISCONTIGMEM to SPARSEMEM
Date: Mon, 16 Sep 2019 12:52:35 +0300 [thread overview]
Message-ID: <20190916095233.GB5196@rapoport-lnx> (raw)
In-Reply-To: <20190916090705.GA5119@alpha.franken.de>
On Mon, Sep 16, 2019 at 11:07:05AM +0200, Thomas Bogendoerfer wrote:
> On Sat, Sep 14, 2019 at 11:41:13AM +0100, Mike Rapoport wrote:
> > On Thu, Sep 12, 2019 at 04:09:12PM +0200, Thomas Bogendoerfer wrote:
> > > On Thu, Sep 12, 2019 at 03:55:39PM +0200, Thomas Bogendoerfer wrote:
> > > > - reserved[0xd] [0x000000035bff8000-0x000000035bffffff], 0x0000000000008000 bytes flags: 0x0
> > > >
> > > > I have no idea which reservation this is, but it's not from one of the
> > > > node data.
> > >
> > > that's sparsemem's mem_section. And
> > >
> > > free_bootmem_with_active_regions(node, end_pfn);
> >
> > It seems that the call to free_bootmem_with_active_regions() should have
> > been removed along with bootmem and it's not needed now.
> >
> > Can you please test the below version of the patch?
>
> Patch is good. I've compared bootlogs and output is the same
> regarding memblock/memory debug messages.
Can I add your co-developed+signed-off then?
> When this is merged, I'll have a look into using memblock_alloc
> for the node memory.
>
> Thomas.
>
> --
> Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
> good idea. [ RFC1925, 2.3 ]
--
Sincerely yours,
Mike.
next prev parent reply other threads:[~2019-09-16 9:52 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-05 5:47 [PATCH] mips: sgi-ip27: switch from DISCONTIGMEM to SPARSEMEM Mike Rapoport
2019-09-05 13:21 ` Thomas Bogendoerfer
2019-09-05 13:32 ` Mike Rapoport
2019-09-05 13:48 ` Thomas Bogendoerfer
2019-09-05 15:47 ` Mike Rapoport
2019-09-05 21:38 ` Thomas Bogendoerfer
2019-09-06 13:02 ` Mike Rapoport
2019-09-09 16:22 ` Thomas Bogendoerfer
2019-09-10 11:32 ` Mike Rapoport
2019-09-10 12:44 ` Thomas Bogendoerfer
2019-09-11 14:09 ` Thomas Bogendoerfer
2019-09-11 14:57 ` Mike Rapoport
2019-09-12 10:58 ` Mike Rapoport
2019-09-12 13:55 ` Thomas Bogendoerfer
2019-09-12 14:09 ` Thomas Bogendoerfer
2019-09-12 15:58 ` Mike Rapoport
2019-09-14 10:41 ` Mike Rapoport
2019-09-16 9:07 ` Thomas Bogendoerfer
2019-09-16 9:52 ` Mike Rapoport [this message]
2019-09-16 10:07 ` Thomas Bogendoerfer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190916095233.GB5196@rapoport-lnx \
--to=rppt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=paul.burton@mips.com \
--cc=rppt@linux.ibm.com \
--cc=tsbogend@alpha.franken.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).