From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 90CF0C4CECD for ; Tue, 17 Sep 2019 10:55:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6DB5221670 for ; Tue, 17 Sep 2019 10:55:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727494AbfIQKzZ (ORCPT ); Tue, 17 Sep 2019 06:55:25 -0400 Received: from smtp2.goneo.de ([85.220.129.33]:43380 "EHLO smtp2.goneo.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726141AbfIQKzZ (ORCPT ); Tue, 17 Sep 2019 06:55:25 -0400 Received: from localhost (localhost [127.0.0.1]) by smtp2.goneo.de (Postfix) with ESMTP id E38D423F6EC; Tue, 17 Sep 2019 12:55:22 +0200 (CEST) X-Virus-Scanned: by goneo Received: from smtp2.goneo.de ([127.0.0.1]) by localhost (smtp2.goneo.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id dKXicsz0i760; Tue, 17 Sep 2019 12:55:22 +0200 (CEST) Received: from lem-wkst-02.lemonage (hq.lemonage.de [87.138.178.34]) by smtp2.goneo.de (Postfix) with ESMTPSA id 6D69524013D; Tue, 17 Sep 2019 12:55:21 +0200 (CEST) Date: Tue, 17 Sep 2019 12:55:19 +0200 From: Lars Poeschel To: David Miller Cc: allison@lohutok.net, keescook@chromium.org, opensource@jilayne.com, swinslow@gmail.com, gregkh@linuxfoundation.org, gustavo@embeddedor.com, tglx@linutronix.de, kstewart@linuxfoundation.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, johan@kernel.org Subject: Re: [PATCH v7 6/7] nfc: pn533: Add autopoll capability Message-ID: <20190917105519.GB18936@lem-wkst-02.lemonage> References: <20190910093415.2186-1-poeschel@lemonage.de> <20190911.101759.1557703938346599792.davem@davemloft.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190911.101759.1557703938346599792.davem@davemloft.net> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 11, 2019 at 10:17:59AM +0200, David Miller wrote: > From: Lars Poeschel > Date: Tue, 10 Sep 2019 11:34:12 +0200 > > > +static int pn533_autopoll_complete(struct pn533 *dev, void *arg, > > + struct sk_buff *resp) > > +{ > > + u8 nbtg; > > + int rc; > > + struct pn532_autopoll_resp *apr; > > + struct nfc_target nfc_tgt; > > Need reverse christmas tree here. See below. > > @@ -1534,6 +1655,7 @@ static int pn533_start_poll(struct nfc_dev *nfc_dev, > > struct pn533_poll_modulations *cur_mod; > > u8 rand_mod; > > int rc; > > + struct sk_buff *skb; > > Likewise. I will do a v8 with these changes soon.