From: Lars Poeschel <poeschel@lemonage.de>
To: David Miller <davem@davemloft.net>
Cc: gregkh@linuxfoundation.org, tglx@linutronix.de,
kstewart@linuxfoundation.org, swinslow@gmail.com,
allison@lohutok.net, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org, johan@kernel.org,
Claudiu.Beznea@microchip.com
Subject: Re: [PATCH v7 5/7] nfc: pn533: add UART phy driver
Date: Tue, 17 Sep 2019 12:56:09 +0200 [thread overview]
Message-ID: <20190917105609.GC18936@lem-wkst-02.lemonage> (raw)
In-Reply-To: <20190911.101732.1453519960272118746.davem@davemloft.net>
On Wed, Sep 11, 2019 at 10:17:32AM +0200, David Miller wrote:
> From: Lars Poeschel <poeschel@lemonage.de>
> Date: Tue, 10 Sep 2019 11:33:50 +0200
>
> > +static int pn532_uart_send_ack(struct pn533 *dev, gfp_t flags)
> > +{
> > + struct pn532_uart_phy *pn532 = dev->phy;
> > + /* spec 7.1.1.3: Preamble, SoPC (2), ACK Code (2), Postamble */
> > + static const u8 ack[PN533_STD_FRAME_ACK_SIZE] = {
> > + 0x00, 0x00, 0xff, 0x00, 0xff, 0x00};
> > + int err;
>
> Reverse christmas tree ordering for the local variables please.
See below.
> > +static int pn532_uart_rx_is_frame(struct sk_buff *skb)
> > +{
> > + int i;
> > + u16 frame_len;
> > + struct pn533_std_frame *std;
> > + struct pn533_ext_frame *ext;
>
> Likewise.
Ok, I will do a v8 soon with these changes.
prev parent reply other threads:[~2019-09-17 10:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-10 9:33 [PATCH v7 5/7] nfc: pn533: add UART phy driver Lars Poeschel
2019-09-11 8:17 ` David Miller
2019-09-17 10:56 ` Lars Poeschel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190917105609.GC18936@lem-wkst-02.lemonage \
--to=poeschel@lemonage.de \
--cc=Claudiu.Beznea@microchip.com \
--cc=allison@lohutok.net \
--cc=davem@davemloft.net \
--cc=gregkh@linuxfoundation.org \
--cc=johan@kernel.org \
--cc=kstewart@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=swinslow@gmail.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).