From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AD5BFC4CECD for ; Tue, 17 Sep 2019 10:08:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7BE3221881 for ; Tue, 17 Sep 2019 10:08:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726993AbfIQKI6 (ORCPT ); Tue, 17 Sep 2019 06:08:58 -0400 Received: from mx1.redhat.com ([209.132.183.28]:35542 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725901AbfIQKI6 (ORCPT ); Tue, 17 Sep 2019 06:08:58 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 23A6110DCC84; Tue, 17 Sep 2019 10:08:58 +0000 (UTC) Received: from gondolin (dhcp-192-230.str.redhat.com [10.33.192.230]) by smtp.corp.redhat.com (Postfix) with ESMTP id 962E760126; Tue, 17 Sep 2019 10:08:54 +0000 (UTC) Date: Tue, 17 Sep 2019 12:08:52 +0200 From: Cornelia Huck To: Parav Pandit Cc: alex.williamson@redhat.com, jiri@mellanox.com, kwankhede@nvidia.com, davem@davemloft.net, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH v3 3/5] mdev: Expose mdev alias in sysfs tree Message-ID: <20190917120852.0f6ec4cc.cohuck@redhat.com> In-Reply-To: <20190902042436.23294-4-parav@mellanox.com> References: <20190826204119.54386-1-parav@mellanox.com> <20190902042436.23294-1-parav@mellanox.com> <20190902042436.23294-4-parav@mellanox.com> Organization: Red Hat GmbH MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.6.2 (mx1.redhat.com [10.5.110.64]); Tue, 17 Sep 2019 10:08:58 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 1 Sep 2019 23:24:34 -0500 Parav Pandit wrote: > Expose the optional alias for an mdev device as a sysfs attribute. > This way, userspace tools such as udev may make use of the alias, for > example to create a netdevice name for the mdev. > > Updated documentation for optional read only sysfs attribute. > > Signed-off-by: Parav Pandit > > --- > Changelog: > v2->v3: > - Merged sysfs documentation patch with sysfs addition > - Added more description for alias return value > v0->v1: > - Addressed comments from Cornelia Huck > - Updated commit description > --- > Documentation/driver-api/vfio-mediated-device.rst | 9 +++++++++ > drivers/vfio/mdev/mdev_sysfs.c | 13 +++++++++++++ > 2 files changed, 22 insertions(+) > (...) > @@ -281,6 +282,14 @@ Example:: > > # echo 1 > /sys/bus/mdev/devices/$mdev_UUID/remove > > +* alias (read only, optional) > +Whenever a parent requested to generate an alias, each mdev device of such s/such/that/ > +parent is assigned unique alias by the mdev core. s/unique alias/a unique alias/ > +This file shows the alias of the mdev device. > + > +Reading file either returns valid alias when assigned or returns error code s/file/this file/ s/valid alias/a valid alias/ s/error code/the error code/ > +-EOPNOTSUPP when unsupported. > + > Mediated device Hot plug > ------------------------ With the nits above fixed, Reviewed-by: Cornelia Huck