Re: [PATCH 2/5] powerpc: Map & release OpenCAPI LPC memory

From: kbuild test robot <lkp@intel.com>
To: Alastair D'Silva <alastair@au1.ibm.com>
Cc: kbuild-all@01.org, alastair@d-silva.org,
	"Benjamin Herrenschmidt" <benh@kernel.crashing.org>,
	"Paul Mackerras" <paulus@samba.org>,
	"Michael Ellerman" <mpe@ellerman.id.au>,
	"Frederic Barrat" <fbarrat@linux.ibm.com>,
	"Andrew Donnellan" <ajd@linux.ibm.com>,
	"Arnd Bergmann" <arnd@arndb.de>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	"Mahesh Salgaonkar" <mahesh@linux.vnet.ibm.com>,
	"Allison Randal" <allison@lohutok.net>,
	"Anju T Sudhakar" <anju@linux.vnet.ibm.com>,
	"Vaibhav Jain" <vaibhav@linux.ibm.com>,
	=?unknown-8bit?Q?C=C3=A9dric?= Le Goater <clg@kaod.org>,
	"Thomas Gleixner" <tglx@linutronix.de>,
	"David Gibson" <david@gibson.dropbear.id.au>,
	"Alexey Kardashevskiy" <aik@ozlabs.ru>,
	"Masahiro Yamada" <yamada.masahiro@socionext.com>,
	"Nicholas Piggin" <npiggin@gmail.com>,
	linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/5] powerpc: Map & release OpenCAPI LPC memory
Date: Tue, 17 Sep 2019 12:22:38 +0800	[thread overview]
Message-ID: <201909171259.fepclpk8%lkp@intel.com> (raw)
In-Reply-To: <20190917014307.30485-3-alastair@au1.ibm.com>

[-- Attachment #1: Type: text/plain, Size: 2399 bytes --]

Hi Alastair,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on linus/master]
[cannot apply to v5.3 next-20190916]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Alastair-D-Silva/ocxl-Allow-external-drivers-to-access-LPC-memory/20190917-094857
config: powerpc-allmodconfig (attached as .config)
compiler: powerpc64-linux-gcc (GCC) 7.4.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        GCC_VERSION=7.4.0 make.cross ARCH=powerpc 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   arch/powerpc/platforms/powernv/ocxl.c: In function 'pnv_ocxl_platform_lpc_setup':
>> arch/powerpc/platforms/powernv/ocxl.c:492:7: error: implicit declaration of function 'check_hotplug_memory_addressable' [-Werror=implicit-function-declaration]
     rc = check_hotplug_memory_addressable(base_addr, base_addr + size);
          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   cc1: some warnings being treated as errors

vim +/check_hotplug_memory_addressable +492 arch/powerpc/platforms/powernv/ocxl.c

   477	
   478	u64 pnv_ocxl_platform_lpc_setup(struct pci_dev *pdev, u64 size)
   479	{
   480		struct pci_controller *hose = pci_bus_to_host(pdev->bus);
   481		struct pnv_phb *phb = hose->private_data;
   482		struct pci_dn *pdn = pci_get_pdn(pdev);
   483		u32 bdfn = (pdn->busno << 8) | pdn->devfn;
   484		u64 base_addr = 0;
   485	
   486		int rc = opal_npu_mem_alloc(phb->opal_id, bdfn, size, &base_addr);
   487	
   488		WARN_ON(rc);
   489	
   490		base_addr = be64_to_cpu(base_addr);
   491	
 > 492		rc = check_hotplug_memory_addressable(base_addr, base_addr + size);
   493		if (rc) {
   494			dev_warn(&pdev->dev,
   495				 "LPC memory range 0x%llx-0x%llx is not fully addressable",
   496				 base_addr, base_addr + size - 1);
   497			return 0;
   498		}
   499	
   500	
   501		return base_addr;
   502	}
   503	EXPORT_SYMBOL_GPL(pnv_ocxl_platform_lpc_setup);
   504	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 62351 bytes --]