From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: Vanya Lazeev <ivan.lazeev@gmail.com>
Cc: Peter Huewe <peterhuewe@gmx.de>, Jason Gunthorpe <jgg@ziepe.ca>,
Arnd Bergmann <arnd@arndb.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-integrity@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4] tpm_crb: fix fTPM on AMD Zen+ CPUs
Date: Tue, 17 Sep 2019 22:10:13 +0300 [thread overview]
Message-ID: <20190917190950.GG10244@linux.intel.com> (raw)
In-Reply-To: <20190916200029.GA27567@hv-1.home>
On Mon, Sep 16, 2019 at 11:00:30PM +0300, Vanya Lazeev wrote:
> On Mon, Sep 16, 2019 at 08:51:30AM +0300, Jarkko Sakkinen wrote:
> > On Sat, Sep 14, 2019 at 08:17:44PM +0300, ivan.lazeev@gmail.com wrote:
> > > + struct list_head acpi_resources, crb_resources;
> >
> > Please do not create crb_resources. I said this already last time.
>
> But then, if I'm not mistaken, it will be impossible to track pointers
> to multiple remaped regions. In this particular case, it
> doesn't matter, because both buffers are in different ACPI regions,
> and using acpi_resources only to fix buffer will be enough.
> However, this creates incosistency between single- and
> multiple-region cases: in the latter iobase field of struct crb_priv
> doesn't make any difference. Am I understanding the situation correctly?
> Will such fix be ok?
So why you need to track pointers other than in initialization as devm
will take care of freeing them. Just trying to understand the problem.
/Jarkko
next prev parent reply other threads:[~2019-09-17 19:10 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-14 17:17 [PATCH v4] tpm_crb: fix fTPM on AMD Zen+ CPUs ivan.lazeev
2019-09-16 5:26 ` Jarkko Sakkinen
2019-09-16 5:51 ` Jarkko Sakkinen
2019-09-16 20:00 ` Vanya Lazeev
2019-09-17 19:10 ` Jarkko Sakkinen [this message]
2019-09-17 20:54 ` Vanya Lazeev
2019-09-20 15:02 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190917190950.GG10244@linux.intel.com \
--to=jarkko.sakkinen@linux.intel.com \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=ivan.lazeev@gmail.com \
--cc=jgg@ziepe.ca \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peterhuewe@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).