From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BE8D8C4CEC4 for ; Wed, 18 Sep 2019 12:35:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9A2CA205F4 for ; Wed, 18 Sep 2019 12:35:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731152AbfIRMfD (ORCPT ); Wed, 18 Sep 2019 08:35:03 -0400 Received: from kirsty.vergenet.net ([202.4.237.240]:44648 "EHLO kirsty.vergenet.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725902AbfIRMfD (ORCPT ); Wed, 18 Sep 2019 08:35:03 -0400 Received: from reginn.horms.nl (watermunt.horms.nl [80.127.179.77]) by kirsty.vergenet.net (Postfix) with ESMTPA id C1C8B25AF19; Wed, 18 Sep 2019 22:35:00 +1000 (AEST) Received: by reginn.horms.nl (Postfix, from userid 7100) id EBCA9942C13; Wed, 18 Sep 2019 14:34:57 +0200 (CEST) Date: Wed, 18 Sep 2019 14:34:57 +0200 From: Simon Horman To: Lars Poeschel Cc: Allison Randal , Greg Kroah-Hartman , Jilayne Lovejoy , Kate Stewart , Thomas Gleixner , "open list:NFC SUBSYSTEM" , open list , Johan Hovold Subject: Re: [PATCH v7 1/7] nfc: pn533: i2c: "pn532" as dt compatible string Message-ID: <20190918123457.wg6mtygr6cboqsp6@verge.net.au> References: <20190910093129.1844-1-poeschel@lemonage.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190910093129.1844-1-poeschel@lemonage.de> Organisation: Horms Solutions BV User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 10, 2019 at 11:31:21AM +0200, Lars Poeschel wrote: > It is favourable to have one unified compatible string for devices that > have multiple interfaces. So this adds simply "pn532" as the devicetree > binding compatible string and makes a note that the old ones are > deprecated. Do you also need to update Documentation/devicetree/bindings/net/nfc/pn533-i2c.txt to both document the new compat string and deprecate the old ones? > Cc: Johan Hovold > Signed-off-by: Lars Poeschel > --- > Changes in v6: > - Rebased the patch series on v5.3-rc5 > > Changes in v3: > - This patch is new in v3 > > drivers/nfc/pn533/i2c.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/drivers/nfc/pn533/i2c.c b/drivers/nfc/pn533/i2c.c > index 1832cd921ea7..1abd40398a5a 100644 > --- a/drivers/nfc/pn533/i2c.c > +++ b/drivers/nfc/pn533/i2c.c > @@ -245,6 +245,11 @@ static int pn533_i2c_remove(struct i2c_client *client) > } > > static const struct of_device_id of_pn533_i2c_match[] = { > + { .compatible = "nxp,pn532", }, > + /* > + * NOTE: The use of the compatibles with the trailing "...-i2c" is > + * deprecated and will be removed. > + */ > { .compatible = "nxp,pn533-i2c", }, > { .compatible = "nxp,pn532-i2c", }, > {}, > -- > 2.23.0 >