From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 887DFC4CEC4 for ; Wed, 18 Sep 2019 13:11:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 68E9320644 for ; Wed, 18 Sep 2019 13:11:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729535AbfIRNLN (ORCPT ); Wed, 18 Sep 2019 09:11:13 -0400 Received: from mga14.intel.com ([192.55.52.115]:19830 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727001AbfIRNLN (ORCPT ); Wed, 18 Sep 2019 09:11:13 -0400 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 18 Sep 2019 06:11:12 -0700 X-IronPort-AV: E=Sophos;i="5.64,520,1559545200"; d="scan'208";a="181117768" Received: from paasikivi.fi.intel.com ([10.237.72.42]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 18 Sep 2019 06:11:09 -0700 Received: by paasikivi.fi.intel.com (Postfix, from userid 1000) id A55462075A; Wed, 18 Sep 2019 16:11:07 +0300 (EEST) Date: Wed, 18 Sep 2019 16:11:07 +0300 From: Sakari Ailus To: Joe Perches Cc: Petr Mladek , linux-kernel@vger.kernel.org, rafael@kernel.org, Andy Shevchenko , linux-acpi@vger.kernel.org, devicetree@vger.kernel.org, Rob Herring , Heikki Krogerus Subject: Re: [PATCH v6 11/12] lib/vsprintf: Add %pfw conversion specifier for printing fwnode names Message-ID: <20190918131107.GR5781@paasikivi.fi.intel.com> References: <20190910084707.18380-1-sakari.ailus@linux.intel.com> <20190910084707.18380-12-sakari.ailus@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Joe, On Tue, Sep 10, 2019 at 03:21:26AM -0700, Joe Perches wrote: > > @@ -5988,14 +5988,17 @@ sub process { > > for (my $count = $linenr; $count <= $lc; $count++) { > > my $specifier; > > my $extension; > > + my $qualifier; > > my $bad_specifier = ""; > > my $fmt = get_quoted_string($lines[$count - 1], raw_line($count, 0)); > > $fmt =~ s/%%//g; > > > > - while ($fmt =~ /(\%[\*\d\.]*p(\w))/g) { > > + while ($fmt =~ /(\%[\*\d\.]*p(\w)(\w?))/g) { > > This is not generic enough to allow all possible qualifiers > to be captured. > > This should be something like: > > while ($fmt =~ /(\%[\*\d\.]*p(\w)(\w*))/g) { > > > $specifier = $1; > > $extension = $2; > > - if ($extension !~ /[SsBKRraEhMmIiUDdgVCbGNOxt]/) { > > + $qualifier = $3; > > + if ($extension !~ /[SsBKRraEhMmIiUDdgVCbGNOxtf]/ || > > + ($extension eq "f" && $qualifier ne "w")) { > > > And this should likely test > (defined $qualifier && > $extension eq 'f' && $qualifier =~ /^w/)) > > > $bad_specifier = $specifier; > > last; > > } > > And here the 'f' isn't really a bad $specifier, > it does not have the correct 'w' $extension. > > The valid extensions may change in the future and > this code isn't particularly manageable, so I > think the $specifier/$extension pair should likely > have some additional testing after validating > the $specifier. There are certainly possibilities of having qualifiers that aren't supported but extensions are also allowed to be followed by any other characters, so this is a bit grey area. I'll make the qualifier one or more letters for v7 as you suggested. -- Regards, Sakari Ailus sakari.ailus@linux.intel.com