From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D3B18C4CEC4 for ; Wed, 18 Sep 2019 13:53:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A674721907 for ; Wed, 18 Sep 2019 13:53:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1568814786; bh=tOUTIuyO3zD8mv1/MtmP0yO9cQ9wXjNOnusI3yuBdHk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=avEx1EpT+50qkJMRktdyB3+LXKIUuz1ywXrSqYM9MloIsbkcjyCVIjXmt5/uSUHEX pJhNw5E/Vpl0YK2HldAvuBlloSs18GgzW9TR5OWcndYsi/XUlAxNF8fXWfRaHviOS1 aNcmSqJpTsVlQMRMeoi06bt564u0ABMLnB4XAiUM= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729915AbfIRNxF (ORCPT ); Wed, 18 Sep 2019 09:53:05 -0400 Received: from mail.kernel.org ([198.145.29.99]:53736 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726562AbfIRNxF (ORCPT ); Wed, 18 Sep 2019 09:53:05 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id E62852067B; Wed, 18 Sep 2019 13:53:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1568814784; bh=tOUTIuyO3zD8mv1/MtmP0yO9cQ9wXjNOnusI3yuBdHk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=SzdEEvJEDs9IGneM+AQQk5PuVrIMlKoFeNT24elLCLvjtqmIynpAdH//B2PwS3BS3 2CvOr5oQAZKf61ntvu9rRoWkhJlAHIcv6W5H9nd1JaTUaHeJ7ZMmEl6iDwkVSDTbvn g7bsaeokbrUeneI8Lgkrmdh6IB3iAS4UNwPcSM0s= Date: Wed, 18 Sep 2019 15:53:02 +0200 From: Greg KH To: Pierre-Louis Bossart Cc: alsa-devel@alsa-project.org, tiwai@suse.de, linux-kernel@vger.kernel.org, Ranjani Sridharan , vkoul@kernel.org, broonie@kernel.org, srinivas.kandagatla@linaro.org, jank@cadence.com, slawomir.blauciak@intel.com, Sanyog Kale , Bard liao , Rander Wang Subject: Re: [alsa-devel] [RFC PATCH 8/9] soundwire: intel: remove platform devices and provide new interface Message-ID: <20190918135302.GA1919118@kroah.com> References: <20190916212342.12578-1-pierre-louis.bossart@linux.intel.com> <20190916212342.12578-9-pierre-louis.bossart@linux.intel.com> <20190917055512.GE2058532@kroah.com> <20190918120629.GD1901208@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.12.1 (2019-06-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 18, 2019 at 08:48:33AM -0500, Pierre-Louis Bossart wrote: > On 9/18/19 7:06 AM, Greg KH wrote: > > On Tue, Sep 17, 2019 at 09:29:52AM -0500, Pierre-Louis Bossart wrote: > > > On 9/17/19 12:55 AM, Greg KH wrote: > > > > On Mon, Sep 16, 2019 at 04:23:41PM -0500, Pierre-Louis Bossart wrote: > > > > > +/** > > > > > + * sdw_intel_probe() - SoundWire Intel probe routine > > > > > + * @parent_handle: ACPI parent handle > > > > > + * @res: resource data > > > > > + * > > > > > + * This creates SoundWire Master and Slave devices below the controller. > > > > > + * All the information necessary is stored in the context, and the res > > > > > + * argument pointer can be freed after this step. > > > > > + */ > > > > > +struct sdw_intel_ctx > > > > > +*sdw_intel_probe(struct sdw_intel_res *res) > > > > > +{ > > > > > + return sdw_intel_probe_controller(res); > > > > > +} > > > > > +EXPORT_SYMBOL(sdw_intel_probe); > > > > > + > > > > > +/** > > > > > + * sdw_intel_startup() - SoundWire Intel startup > > > > > + * @ctx: SoundWire context allocated in the probe > > > > > + * > > > > > + */ > > > > > +int sdw_intel_startup(struct sdw_intel_ctx *ctx) > > > > > +{ > > > > > + return sdw_intel_startup_controller(ctx); > > > > > +} > > > > > +EXPORT_SYMBOL(sdw_intel_startup); > > > > > > > > Why are you exporting these functions if no one calls them? > > > > > > They are used in the next series, see '[RFC PATCH 04/12] ASoC: SOF: Intel: > > > add SoundWire configuration interface' > > > > That wasn't obvious :) > > > > Also, why not EXPORT_SYMBOL_GPL()? :) > > Since the beginning of this SoundWire work, the intent what that the code > could be reused in non-GPL open-source circles, hence the dual license and > EXPORT_SYMBOL. Hah, you _have_ talked to your lawyers about this, right? You have a chance to do something like this for header files, for .c files, good luck. That's going to be a hard road to go down. Many have tried in the past, all but 1 have failed. > That said, there are cases where the code only makes sense for Linux, or > relies on symbols that are exported with EXPORT_SYMBOL_GPL, in those cases > we rely on GPLv2 and EXPORT_SYMBOL_GPL. For this series I added a disclaimer > in the cover letter that those parts need to be reviewed further to make > sure there are no conflicts with GPL. Please do that with your lawyers, do not require developers to do legal work for you, that's just mean :( thanks, greg k-h