From: Pavel Machek <pavel@ucw.cz>
To: "Guido Günther" <agx@sigxcpu.org>
Cc: Jacek Anaszewski <jacek.anaszewski@gmail.com>,
Dan Murphy <dmurphy@ti.com>,
linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/5] leds: lm3692x: Don't overwrite return value in error path
Date: Thu, 19 Sep 2019 12:57:07 +0200 [thread overview]
Message-ID: <20190919105707.GB29939@amd> (raw)
In-Reply-To: <bc1a6e64da58d65b61c7e9358c745b0d467fc24c.1568772964.git.agx@sigxcpu.org>
[-- Attachment #1: Type: text/plain, Size: 1279 bytes --]
On Tue 2019-09-17 19:19:55, Guido Günther wrote:
> The driver currently reports successful initialization on every failure
> as long as it's able to power off the regulator. Don't check the return
> value of regulator_disable to avoid that.
>
> Signed-off-by: Guido Günther <agx@sigxcpu.org>
> ---
> drivers/leds/leds-lm3692x.c | 9 +++------
> 1 file changed, 3 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/leds/leds-lm3692x.c b/drivers/leds/leds-lm3692x.c
> index 487228c2bed2..f394669ad8f2 100644
> --- a/drivers/leds/leds-lm3692x.c
> +++ b/drivers/leds/leds-lm3692x.c
> @@ -312,15 +312,12 @@ static int lm3692x_init(struct lm3692x_led *led)
> if (led->enable_gpio)
> gpiod_direction_output(led->enable_gpio, 0);
>
> - if (led->regulator) {
> - ret = regulator_disable(led->regulator);
> - if (ret)
> - dev_err(&led->client->dev,
> - "Failed to disable regulator\n");
> - }
> + if (led->regulator)
> + regulator_disable(led->regulator);
>
> return ret;
Overwriting return value is bad, but we should still print some kind
of error message.
Best regards,
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
next prev parent reply other threads:[~2019-09-19 10:57 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-18 2:19 [PATCH 0/5] leds: lm3692x: Probing and flag fixes Guido Günther
2019-09-18 2:19 ` [PATCH 1/5] leds: lm3692x: Print error value on dev_err Guido Günther
2019-09-18 18:23 ` Dan Murphy
2019-09-18 2:19 ` [PATCH 2/5] leds: lm3692x: Don't overwrite return value in error path Guido Günther
2019-09-18 18:33 ` Dan Murphy
2019-09-19 10:57 ` Pavel Machek [this message]
2019-09-18 2:19 ` [PATCH 3/5] leds: lm3692x: Handle failure to probe the regulator Guido Günther
2019-09-18 18:41 ` Dan Murphy
2019-09-18 2:19 ` [PATCH 4/5] leds: lm3692x: Use flags from LM3692X_BOOST_CTRL Guido Günther
2019-09-18 18:46 ` Dan Murphy
2019-09-18 2:19 ` [PATCH 5/5] leds: lm3692x: Use flags from LM3692X_BRT_CTRL Guido Günther
2019-09-18 18:48 ` Dan Murphy
2019-09-19 9:54 ` [PATCH 0/5] leds: lm3692x: Probing and flag fixes Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190919105707.GB29939@amd \
--to=pavel@ucw.cz \
--cc=agx@sigxcpu.org \
--cc=dmurphy@ti.com \
--cc=jacek.anaszewski@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).