From: Philipp Puschmann <philipp.puschmann@emlix.com>
To: linux-kernel@vger.kernel.org
Cc: yibin.gong@nxp.com, fugang.duan@nxp.com, l.stach@pengutronix.de,
dan.j.williams@intel.com, vkoul@kernel.org, shawnguo@kernel.org,
s.hauer@pengutronix.de, kernel@pengutronix.de,
festevam@gmail.com, linux-imx@nxp.com, dmaengine@vger.kernel.or,
linux-arm-kernel@lists.infradead.org,
Philipp Puschmann <philipp.puschmann@emlix.com>
Subject: [PATCH v4 3/3] dmaengine: imx-sdma: drop redundant variable
Date: Thu, 19 Sep 2019 16:29:41 +0200 [thread overview]
Message-ID: <20190919142942.12469-4-philipp.puschmann@emlix.com> (raw)
In-Reply-To: <20190919142942.12469-1-philipp.puschmann@emlix.com>
In sdma_prep_dma_cyclic buf is redundant. Drop it.
Signed-off-by: Philipp Puschmann <philipp.puschmann@emlix.com>
Reviewed-by: Lucas Stach <l.stach@pengutronix.de>
---
Changelog v3,v4:
- no changes
Changelog v2:
- add Reviewed-by tag
drivers/dma/imx-sdma.c | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/drivers/dma/imx-sdma.c b/drivers/dma/imx-sdma.c
index a32b5962630e..17961451941a 100644
--- a/drivers/dma/imx-sdma.c
+++ b/drivers/dma/imx-sdma.c
@@ -1544,7 +1544,7 @@ static struct dma_async_tx_descriptor *sdma_prep_dma_cyclic(
struct sdma_engine *sdma = sdmac->sdma;
int num_periods = buf_len / period_len;
int channel = sdmac->channel;
- int i = 0, buf = 0;
+ int i;
struct sdma_desc *desc;
dev_dbg(sdma->dev, "%s channel: %d\n", __func__, channel);
@@ -1565,7 +1565,7 @@ static struct dma_async_tx_descriptor *sdma_prep_dma_cyclic(
goto err_bd_out;
}
- while (buf < buf_len) {
+ for (i = 0; i < num_periods; i++) {
struct sdma_buffer_descriptor *bd = &desc->bd[i];
int param;
@@ -1592,9 +1592,6 @@ static struct dma_async_tx_descriptor *sdma_prep_dma_cyclic(
bd->mode.status = param;
dma_addr += period_len;
- buf += period_len;
-
- i++;
}
return vchan_tx_prep(&sdmac->vc, &desc->vd, flags);
--
2.23.0
next prev parent reply other threads:[~2019-09-19 14:29 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-19 14:29 [PATCH v4 0/3] Fix UART DMA freezes for i.MX SOCs Philipp Puschmann
2019-09-19 14:29 ` [PATCH v4 1/3] dmaengine: imx-sdma: fix buffer ownership Philipp Puschmann
2019-09-19 14:29 ` [PATCH v4 2/3] dmaengine: imx-sdma: fix dma freezes Philipp Puschmann
2019-09-19 15:19 ` Jan Lübbe
2019-09-20 8:53 ` Philipp Puschmann
2019-09-20 9:26 ` Lucas Stach
2019-09-24 1:38 ` Robin Gong
2019-09-19 14:29 ` Philipp Puschmann [this message]
2019-09-20 2:44 ` [EXT] [PATCH v4 0/3] Fix UART DMA freezes for i.MX SOCs Andy Duan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190919142942.12469-4-philipp.puschmann@emlix.com \
--to=philipp.puschmann@emlix.com \
--cc=dan.j.williams@intel.com \
--cc=dmaengine@vger.kernel.or \
--cc=festevam@gmail.com \
--cc=fugang.duan@nxp.com \
--cc=kernel@pengutronix.de \
--cc=l.stach@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=vkoul@kernel.org \
--cc=yibin.gong@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).