From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D298FC4CEC4 for ; Thu, 19 Sep 2019 16:51:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B463A206C2 for ; Thu, 19 Sep 2019 16:51:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389253AbfISQvX (ORCPT ); Thu, 19 Sep 2019 12:51:23 -0400 Received: from mx1.redhat.com ([209.132.183.28]:33680 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726007AbfISQvW (ORCPT ); Thu, 19 Sep 2019 12:51:22 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id B938530860CF; Thu, 19 Sep 2019 16:51:22 +0000 (UTC) Received: from treble (ovpn-123-153.rdu2.redhat.com [10.10.123.153]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 7CE751001B00; Thu, 19 Sep 2019 16:51:21 +0000 (UTC) Date: Thu, 19 Sep 2019 11:51:18 -0500 From: Josh Poimboeuf To: Randy Dunlap Cc: Mark Brown , Linux Next Mailing List , Linux Kernel Mailing List , Peter Zijlstra Subject: Re: linux-next: Tree for Sep 18 (objtool) Message-ID: <20190919165118.lffzvrl5efbpnvux@treble> References: <20190918221053.GV2596@sirena.co.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20180716 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.44]); Thu, 19 Sep 2019 16:51:22 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 18, 2019 at 09:04:21PM -0700, Randy Dunlap wrote: > On 9/18/19 3:10 PM, Mark Brown wrote: > > Hi all, > > > > Changes since 20190917: > > > > on x86_64: > > drivers/gpu/drm/i915/gem/i915_gem_execbuffer.o: warning: objtool: i915_gem_execbuffer2_ioctl()+0x2fb: call to gen8_canonical_addr() with UACCESS enabled > > using > > gcc --version > gcc (SUSE Linux) 7.4.1 20190424 [gcc-7-branch revision 270538] > > .o and .config files are attached. Does this fix it? diff --git a/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c b/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c index b5f6937369ea..7e111cb5b14b 100644 --- a/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c +++ b/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c @@ -284,7 +284,7 @@ struct i915_execbuffer { * canonical form [63:48] == [47]." */ #define GEN8_HIGH_ADDRESS_BIT 47 -static inline u64 gen8_canonical_addr(u64 address) +static __always_inline u64 gen8_canonical_addr(u64 address) { return sign_extend64(address, GEN8_HIGH_ADDRESS_BIT); } -- Josh