From: Benoit Parrot <bparrot@ti.com>
To: Hans Verkuil <hverkuil@xs4all.nl>,
Sakari Ailus <sakari.ailus@linux.intel.com>
Cc: Prabhakar Lad <prabhakar.csengg@gmail.com>,
<linux-media@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, Benoit Parrot <bparrot@ti.com>,
Jyri Sarha <jsarha@ti.com>
Subject: [Patch v2 1/7] media: i2c: ov2659: Fix for image wrap-around in lower resolution
Date: Thu, 19 Sep 2019 15:39:49 -0500 [thread overview]
Message-ID: <20190919203955.15125-2-bparrot@ti.com> (raw)
In-Reply-To: <20190919203955.15125-1-bparrot@ti.com>
Based on recently found sensor configuration examples, it was
discovered that when scaling and binning are used for the lower
resolutions (i.e. 640x480, 320x240) the read offset has to be
increased otherwise the image appears to be wrapped around.
Signed-off-by: Benoit Parrot <bparrot@ti.com>
Signed-off-by: Jyri Sarha <jsarha@ti.com>
---
drivers/media/i2c/ov2659.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/media/i2c/ov2659.c b/drivers/media/i2c/ov2659.c
index f4ded0669ff9..17573257097d 100644
--- a/drivers/media/i2c/ov2659.c
+++ b/drivers/media/i2c/ov2659.c
@@ -661,7 +661,7 @@ static struct sensor_register ov2659_vga[] = {
{ REG_TIMING_HORIZ_FORMAT, 0x01 },
{ 0x370a, 0x52 },
{ REG_VFIFO_READ_START_H, 0x00 },
- { REG_VFIFO_READ_START_L, 0x80 },
+ { REG_VFIFO_READ_START_L, 0xa0 },
{ REG_ISP_CTRL02, 0x10 },
{ REG_NULL, 0x00 },
};
@@ -709,7 +709,7 @@ static struct sensor_register ov2659_qvga[] = {
{ REG_TIMING_HORIZ_FORMAT, 0x01 },
{ 0x370a, 0x52 },
{ REG_VFIFO_READ_START_H, 0x00 },
- { REG_VFIFO_READ_START_L, 0x80 },
+ { REG_VFIFO_READ_START_L, 0xa0 },
{ REG_ISP_CTRL02, 0x10 },
{ REG_NULL, 0x00 },
};
--
2.17.1
next prev parent reply other threads:[~2019-09-19 20:37 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-19 20:39 [Patch v2 0/7] media: i2c: ov2659: maintenance series Benoit Parrot
2019-09-19 20:39 ` Benoit Parrot [this message]
2019-09-19 20:39 ` [Patch v2 2/7] media: i2c: ov2659: Fix sensor detection to actually fail when device is not present Benoit Parrot
2019-09-19 20:39 ` [Patch v2 3/7] media: i2c: ov2659: Cleanup include file list Benoit Parrot
2019-09-19 20:39 ` [Patch v2 4/7] media: dt-bindings: ov2659: add powerdown/reset-gpios optional property Benoit Parrot
2019-09-19 20:39 ` [Patch v2 5/7] media: i2c: ov2659: Add powerdown/reset gpio handling Benoit Parrot
2019-09-20 10:17 ` Sakari Ailus
2019-09-20 16:55 ` Benoit Parrot
2019-09-23 6:17 ` Sakari Ailus
2019-09-23 17:05 ` Benoit Parrot
2019-09-23 17:07 ` Sakari Ailus
2019-09-19 20:39 ` [Patch v2 6/7] media: i2c: ov2659: Fix missing 720p register config Benoit Parrot
2019-09-19 20:39 ` [Patch v2 7/7] media: i2c: ov2659: Switch to SPDX Licensing Benoit Parrot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190919203955.15125-2-bparrot@ti.com \
--to=bparrot@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=hverkuil@xs4all.nl \
--cc=jsarha@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=prabhakar.csengg@gmail.com \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).