From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AC0ADC3A5A6 for ; Thu, 19 Sep 2019 22:23:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8166A21929 for ; Thu, 19 Sep 2019 22:23:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1568931808; bh=s3X8KYhopGYFylN09akusJr4NOztZXLrmbfsb8R3yHg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=X5UCpn0/5292wr2r/36XkV4rpSf6LZxr7/DnE6TM8t/fGx/moUW3lN6L0+HVi/eMz uy7A2Ye7tlH852Y40FW0L8Zc6m4nWdaX/zlYoOYDfRA3PwrIqlmu7hv3Fgj/8D3YzV rbByAiqAz1ONSItncxfy+kAC1UsrjOSWjb56v9jY= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2404756AbfISWX1 (ORCPT ); Thu, 19 Sep 2019 18:23:27 -0400 Received: from mail.kernel.org ([198.145.29.99]:39062 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2394176AbfISWXY (ORCPT ); Thu, 19 Sep 2019 18:23:24 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B034520678; Thu, 19 Sep 2019 22:23:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1568931804; bh=s3X8KYhopGYFylN09akusJr4NOztZXLrmbfsb8R3yHg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=h+/ZYrdb+jhFzmOusHXiNU6Pk6k4RgXG7kIg4O9sOOhevU25RGFLYOAJeJIhdbZEN Q4KfCf7RbJDwONweRmnTLg9hCBehY/Btb/q7agTucIlObirmSZCzT66vXUZa9kF2bi 0xXMW809AGEt18Nbjx0Y+iRGrOe6sROSaJcuzhfk= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Jan Stancek , Naresh Kamboju , Trond Myklebust , Sasha Levin Subject: [PATCH 4.4 46/56] NFSv2: Fix write regression Date: Fri, 20 Sep 2019 00:04:27 +0200 Message-Id: <20190919214801.282028438@linuxfoundation.org> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20190919214742.483643642@linuxfoundation.org> References: <20190919214742.483643642@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Trond Myklebust [ Upstream commit d33d4beb522987d1c305c12500796f9be3687dee ] Ensure we update the write result count on success, since the RPC call itself does not do so. Reported-by: Jan Stancek Reported-by: Naresh Kamboju Signed-off-by: Trond Myklebust Tested-by: Jan Stancek Signed-off-by: Sasha Levin --- fs/nfs/proc.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/fs/nfs/proc.c b/fs/nfs/proc.c index 80ecdf2ec8b6a..b83e14ad13c45 100644 --- a/fs/nfs/proc.c +++ b/fs/nfs/proc.c @@ -610,8 +610,10 @@ static int nfs_proc_pgio_rpc_prepare(struct rpc_task *task, static int nfs_write_done(struct rpc_task *task, struct nfs_pgio_header *hdr) { - if (task->tk_status >= 0) + if (task->tk_status >= 0) { + hdr->res.count = hdr->args.count; nfs_writeback_update_inode(hdr); + } return 0; } -- 2.20.1