From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D8B8AC3A5A6 for ; Thu, 19 Sep 2019 22:08:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id AE10C21907 for ; Thu, 19 Sep 2019 22:08:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1568930914; bh=jsxjZ6c2pKwOfwzh1srusN1d3KgkyddtgzEIeAdJ3vY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=GIS/8BEuHj8cnR8uzkwxZoUPA0mTNKS3zL4fZrAW6WVK5MBMqCIg++wTeAPr4j0EU 6RwXhmFbpneuvjEYSf6ECJzlu1pWGn3/N77ikZqkcERdJb2AQrpV8hcxrcpYNXR4Cz NrKutmkIBafTK3n+NC+QLnICHsqcqZNTX8drOFdQ= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2393448AbfISWId (ORCPT ); Thu, 19 Sep 2019 18:08:33 -0400 Received: from mail.kernel.org ([198.145.29.99]:46400 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2393431AbfISWI3 (ORCPT ); Thu, 19 Sep 2019 18:08:29 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 0739A21A49; Thu, 19 Sep 2019 22:08:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1568930908; bh=jsxjZ6c2pKwOfwzh1srusN1d3KgkyddtgzEIeAdJ3vY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Tsqj87Hf1apoNsV5OWlo1DtDzc2eLz/DlYLV/pNwFXFFj0We24UbmGe+w0mGf6Kn9 dXNww/twPZbuJsWRt/45kYkBX1J6L0kM6BpFQwQxY4RnZ+pQnT8Qdw+Vk+iblcEKII ecXW7vJpJSqHvniSjkWrYqtje4tFyqZ0IaHLABEA= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Wenwen Wang , Sudarsana Reddy Kalluru , "David S. Miller" , Sasha Levin Subject: [PATCH 5.2 058/124] qed: Add cleanup in qed_slowpath_start() Date: Fri, 20 Sep 2019 00:02:26 +0200 Message-Id: <20190919214821.110406518@linuxfoundation.org> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20190919214819.198419517@linuxfoundation.org> References: <20190919214819.198419517@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Wenwen Wang [ Upstream commit de0e4fd2f07ce3bbdb69dfb8d9426b7227451b69 ] If qed_mcp_send_drv_version() fails, no cleanup is executed, leading to memory leaks. To fix this issue, introduce the label 'err4' to perform the cleanup work before returning the error. Signed-off-by: Wenwen Wang Acked-by: Sudarsana Reddy Kalluru Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/net/ethernet/qlogic/qed/qed_main.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/qlogic/qed/qed_main.c b/drivers/net/ethernet/qlogic/qed/qed_main.c index 6de23b56b2945..c875a2fa75966 100644 --- a/drivers/net/ethernet/qlogic/qed/qed_main.c +++ b/drivers/net/ethernet/qlogic/qed/qed_main.c @@ -1215,7 +1215,7 @@ static int qed_slowpath_start(struct qed_dev *cdev, &drv_version); if (rc) { DP_NOTICE(cdev, "Failed sending drv version command\n"); - return rc; + goto err4; } } @@ -1223,6 +1223,8 @@ static int qed_slowpath_start(struct qed_dev *cdev, return 0; +err4: + qed_ll2_dealloc_if(cdev); err3: qed_hw_stop(cdev); err2: -- 2.20.1