From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5903BC3A5A2 for ; Fri, 20 Sep 2019 17:56:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 32B31208C0 for ; Fri, 20 Sep 2019 17:56:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=netronome-com.20150623.gappssmtp.com header.i=@netronome-com.20150623.gappssmtp.com header.b="U3SmG6Mq" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2405830AbfITR4i (ORCPT ); Fri, 20 Sep 2019 13:56:38 -0400 Received: from mail-qt1-f194.google.com ([209.85.160.194]:40725 "EHLO mail-qt1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2392426AbfITR4i (ORCPT ); Fri, 20 Sep 2019 13:56:38 -0400 Received: by mail-qt1-f194.google.com with SMTP id x5so9637612qtr.7 for ; Fri, 20 Sep 2019 10:56:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netronome-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :organization:mime-version:content-transfer-encoding; bh=xwXwb0VRr0Y5mbIrCdrhW15Qm4cGAzoeDVJ2lEpfOz8=; b=U3SmG6MqU1G3DvKMpMi11blBiYYiRG4IcOO9Awa0gS87SZtXwHxfRAO+oIJ9MK0/EA Y5Nsta25gV6EmMx5g/TCw3dF35cXtaZf4UJQ2ybwL38/fuf5L0gSLWl/pIgkAy/Tr/9W 9lOEUdnL6ZM0CekQcwazwaVgejdB3SGe6ZWzCcI24li08Gqx59nLfW91oHIlP8XTnHGZ 8rVb6AExkrDnCzj8p+HKIxY250lw4QXE+FgqHm2qbRqX/YbEWhYwnNj0plotZ8P4mjFL YVQUH4FOhow4YLVAXaWBn0aBFQjADYeLIIcVijsmpWz5SUH2FgLmopUo3+6vwdV+rEDp IaDA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:organization:mime-version:content-transfer-encoding; bh=xwXwb0VRr0Y5mbIrCdrhW15Qm4cGAzoeDVJ2lEpfOz8=; b=IVBHz7cpPxeS6YmoDu7Hq6lSQQ/mlXti1uL3NalP4/Yvnbr2a60FALrVOHHqYy/iKr SLxydBZ0V2lBN+LtfpCXNOguMppu833SeQlM1prE4+njfRD1E3jLbHgEln2nQY4L/le+ Qmhy9KHo2W80416gWMnwpGdPSxZuwZDAGY9dc7L89saCN5r3aPhDvW4vU0dImSluBdEM 1emTZDekmYPBIxGxvY/5ruHSwSgDw8ktSuxT80D/N464GSRRzmNN9OPatUH85c5dPWGZ P53WCEdFPcUaofqVheWaXCPnwyYQVaACzkzGUL9u2b9G8glxBmr7PuW1HRz7XeRs7QK0 rzIA== X-Gm-Message-State: APjAAAV/PilrhZhxHfXdO5ZZAfqM4nUDC9q88I1hOZj2FDnbe8OZc6nF IxHoVfSTep3AodNzGBMdkTcLxA== X-Google-Smtp-Source: APXvYqzUx+S3hfpDDdk07qdwvak3LptBgH6Z52kWxHyuo6TSEFqvvIY8MMZv6cgKWhdxOKPG8VCRTg== X-Received: by 2002:ac8:3fd2:: with SMTP id v18mr4595140qtk.73.1569002197003; Fri, 20 Sep 2019 10:56:37 -0700 (PDT) Received: from cakuba.netronome.com ([66.60.152.14]) by smtp.gmail.com with ESMTPSA id e42sm1322992qte.26.2019.09.20.10.56.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Sep 2019 10:56:36 -0700 (PDT) Date: Fri, 20 Sep 2019 10:56:31 -0700 From: Jakub Kicinski To: =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= , Johannes Berg Cc: "David S . Miller" , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Jouni Malinen , hostap@lists.infradead.org, openwrt-devel@lists.openwrt.org, =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= Subject: Re: [PATCH RFC] cfg80211: add new command for reporting wiphy crashes Message-ID: <20190920105631.34f10d79@cakuba.netronome.com> In-Reply-To: <20190920133708.15313-1-zajec5@gmail.com> References: <20190920133708.15313-1-zajec5@gmail.com> Organization: Netronome Systems, Ltd. MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 20 Sep 2019 15:37:08 +0200, Rafa=C5=82 Mi=C5=82ecki wrote: > From: Rafa=C5=82 Mi=C5=82ecki >=20 > Hardware or firmware instability may result in unusable wiphy. In such > cases usually a hardware reset is needed. To allow a full recovery > kernel has to indicate problem to the user space. >=20 > This new nl80211 command lets user space known wiphy has crashed and has > been just recovered. When applicable it should result in supplicant or > authenticator reconfiguring all interfaces. >=20 > Signed-off-by: Rafa=C5=82 Mi=C5=82ecki > --- > I'd like to use this new cfg80211_crash_report() in brcmfmac after a > successful recovery from a FullMAC firmware crash. >=20 > Later on I'd like to modify hostapd to reconfigure wiphy using a > previously used setup. >=20 > I'm OpenWrt developer & user and I got annoyed by my devices not auto > recovering after various failures. There are things I cannot fix (hw > failures or closed fw crashes) but I still expect my devices to get > back to operational state as soon as possible on their own. Perhaps a slightly larger point, but I think it should be raised -=20 is there any chance for reusing debugging, reset and recovery work done in devlink originally for complex Ethernet devices? WiFi drivers have been dealing with more complex/FW heavy designs for a while so maybe you've grow your own interfaces, and maybe they necessarily need to be 802.11-centric, but I'm a little surprised that: linux $ git grep devlink -- drivers/net/wireless/ linux $