From: Cornelia Huck <cohuck@redhat.com>
To: Matthew Rosato <mjrosato@linux.ibm.com>
Cc: sebott@linux.ibm.com, gerald.schaefer@de.ibm.com,
pasic@linux.ibm.com, borntraeger@de.ibm.com,
walling@linux.ibm.com, linux-s390@vger.kernel.org,
iommu@lists.linux-foundation.org, joro@8bytes.org,
linux-kernel@vger.kernel.org, alex.williamson@redhat.com,
kvm@vger.kernel.org, heiko.carstens@de.ibm.com,
robin.murphy@arm.com, gor@linux.ibm.com, pmorel@linux.ibm.com
Subject: Re: [PATCH v4 4/4] vfio: pci: Using a device region to retrieve zPCI information
Date: Fri, 20 Sep 2019 16:26:07 +0200 [thread overview]
Message-ID: <20190920162607.16198c92.cohuck@redhat.com> (raw)
In-Reply-To: <c5c5c46e-371b-5be0-064a-b89195cdc3f6@linux.ibm.com>
On Thu, 19 Sep 2019 16:57:10 -0400
Matthew Rosato <mjrosato@linux.ibm.com> wrote:
> On 9/19/19 11:25 AM, Cornelia Huck wrote:
> > On Fri, 6 Sep 2019 20:13:51 -0400
> > Matthew Rosato <mjrosato@linux.ibm.com> wrote:
> >
> >> From: Pierre Morel <pmorel@linux.ibm.com>
> >>
> >> We define a new configuration entry for VFIO/PCI, VFIO_PCI_ZDEV
> >>
> >> When the VFIO_PCI_ZDEV feature is configured we initialize
> >> a new device region, VFIO_REGION_SUBTYPE_ZDEV_CLP, to hold
> >> the information from the ZPCI device the use
> >>
> >> Signed-off-by: Pierre Morel <pmorel@linux.ibm.com>
> >> Signed-off-by: Matthew Rosato <mjrosato@linux.ibm.com>
> >> ---
> >> drivers/vfio/pci/Kconfig | 7 +++
> >> drivers/vfio/pci/Makefile | 1 +
> >> drivers/vfio/pci/vfio_pci.c | 9 ++++
> >> drivers/vfio/pci/vfio_pci_private.h | 10 +++++
> >> drivers/vfio/pci/vfio_pci_zdev.c | 85 +++++++++++++++++++++++++++++++++++++
> >> 5 files changed, 112 insertions(+)
> >> create mode 100644 drivers/vfio/pci/vfio_pci_zdev.c
> >>
> >> diff --git a/drivers/vfio/pci/Kconfig b/drivers/vfio/pci/Kconfig
> >> index ac3c1dd..d4562a8 100644
> >> --- a/drivers/vfio/pci/Kconfig
> >> +++ b/drivers/vfio/pci/Kconfig
> >> @@ -45,3 +45,10 @@ config VFIO_PCI_NVLINK2
> >> depends on VFIO_PCI && PPC_POWERNV
> >> help
> >> VFIO PCI support for P9 Witherspoon machine with NVIDIA V100 GPUs
> >> +
> >> +config VFIO_PCI_ZDEV
> >> + bool "VFIO PCI Generic for ZPCI devices"
> >> + depends on VFIO_PCI && S390
> >> + default y
> >> + help
> >> + VFIO PCI support for S390 Z-PCI devices
> >
> >>From that description, I'd have no idea whether I'd want that or not.
> > Is there any downside to enabling it?
> >
>
> :) Not really, you're just getting information from the hardware vs
> using hard-coded defaults. The only reason I could think of to turn it
> off would be if you wanted/needed to restore this hard-coded behavior.
I'm not really sure whether that's worth adding a Kconfig switch for.
Won't older versions simply ignore the new region anyway?
Also, I don't think we have any migration compatibility issues, as
vfio-pci devices are not (yet) migrateable anyway.
>
> bool "VFIO PCI support for generic ZPCI devices" ?
"Support zPCI-specific configuration for VFIO PCI" ?
>
> "Support for sharing ZPCI hardware device information between the host
> and guests." ?
"Enabling this options exposes a region containing hardware
configuration for zPCI devices. This enables userspace (e.g. QEMU) to
supply proper configuration values instead of hard-coded defaults for
zPCI devices passed through via VFIO on s390.
Say Y here."
?
next prev parent reply other threads:[~2019-09-20 14:27 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-07 0:13 [PATCH v4 0/4] Retrieving zPCI specific info with VFIO Matthew Rosato
2019-09-07 0:13 ` [PATCH v4 1/4] s390: pci: Exporting access to CLP PCI function and PCI group Matthew Rosato
2019-09-07 0:13 ` [PATCH v4 2/4] s390: pci: Define the maxstbl CLP response entry Matthew Rosato
2019-09-07 0:13 ` [PATCH v4 3/4] vfio: zpci: defining the VFIO headers Matthew Rosato
2019-09-19 15:20 ` Cornelia Huck
2019-09-19 20:55 ` Matthew Rosato
2019-09-19 22:27 ` Alex Williamson
2019-09-19 22:49 ` Alex Williamson
2019-09-20 14:46 ` Matthew Rosato
2019-09-20 14:02 ` Cornelia Huck
2019-09-20 15:14 ` Matthew Rosato
2019-10-08 13:30 ` Cornelia Huck
2019-09-07 0:13 ` [PATCH v4 4/4] vfio: pci: Using a device region to retrieve zPCI information Matthew Rosato
2019-09-19 15:25 ` Cornelia Huck
2019-09-19 20:57 ` Matthew Rosato
2019-09-20 14:26 ` Cornelia Huck [this message]
2019-09-20 15:53 ` Matthew Rosato
2019-09-19 22:57 ` Alex Williamson
2019-09-20 14:57 ` Matthew Rosato
2019-09-19 1:36 ` [PATCH v4 0/4] Retrieving zPCI specific info with VFIO Matthew Rosato
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190920162607.16198c92.cohuck@redhat.com \
--to=cohuck@redhat.com \
--cc=alex.williamson@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=gerald.schaefer@de.ibm.com \
--cc=gor@linux.ibm.com \
--cc=heiko.carstens@de.ibm.com \
--cc=iommu@lists.linux-foundation.org \
--cc=joro@8bytes.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=mjrosato@linux.ibm.com \
--cc=pasic@linux.ibm.com \
--cc=pmorel@linux.ibm.com \
--cc=robin.murphy@arm.com \
--cc=sebott@linux.ibm.com \
--cc=walling@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).