From: kbuild test robot <lkp@intel.com>
To: Jean-Jacques Hiblot <jjhiblot@ti.com>
Cc: kbuild-all@01.org, jacek.anaszewski@gmail.com, pavel@ucw.cz,
daniel.thompson@linaro.org, linux-leds@vger.kernel.org,
linux-kernel@vger.kernel.org, dmurphy@ti.com,
tomi.valkeinen@ti.com, Jean-Jacques Hiblot <jjhiblot@ti.com>
Subject: Re: [PATCH v4 1/3] led: make led_set_brightness_sync() use led_set_brightness_nosleep()
Date: Sun, 22 Sep 2019 00:13:35 +0800 [thread overview]
Message-ID: <20190921161335.GG13569@xsang-OptiPlex-9020> (raw)
In-Reply-To: <20190920122525.15712-2-jjhiblot@ti.com>
[-- Attachment #1: Type: text/plain, Size: 3017 bytes --]
Hi Jean-Jacques,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on linus/master]
[cannot apply to v5.3 next-20190919]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url: https://github.com/0day-ci/linux/commits/Jean-Jacques-Hiblot/leds-Add-control-of-the-voltage-current-regulator-to-the-LED-core/20190920-220416
config: sh-allmodconfig (attached as .config)
compiler: sh4-linux-gcc (GCC) 7.4.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
GCC_VERSION=7.4.0 make.cross ARCH=sh
:::::: branch date: 2 hours ago
:::::: commit date: 2 hours ago
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
drivers//leds/led-core.c: In function 'led_set_brightness_sync':
>> drivers//leds/led-core.c:302:6: error: void value not ignored as it ought to be
ret = led_set_brightness_nosleep(led_cdev, value);
^
# https://github.com/0day-ci/linux/commit/54301e6f4e910f292045a1afa62ef732791e1bb5
git remote add linux-review https://github.com/0day-ci/linux
git remote update linux-review
git checkout 54301e6f4e910f292045a1afa62ef732791e1bb5
vim +302 drivers//leds/led-core.c
81fe8e5b73e3f4 Jacek Anaszewski 2015-10-07 293
13ae79bbe4c214 Jacek Anaszewski 2015-10-07 294 int led_set_brightness_sync(struct led_classdev *led_cdev,
13ae79bbe4c214 Jacek Anaszewski 2015-10-07 295 enum led_brightness value)
13ae79bbe4c214 Jacek Anaszewski 2015-10-07 296 {
54301e6f4e910f Jean-Jacques Hiblot 2019-09-20 297 int ret;
54301e6f4e910f Jean-Jacques Hiblot 2019-09-20 298
13ae79bbe4c214 Jacek Anaszewski 2015-10-07 299 if (led_cdev->blink_delay_on || led_cdev->blink_delay_off)
13ae79bbe4c214 Jacek Anaszewski 2015-10-07 300 return -EBUSY;
13ae79bbe4c214 Jacek Anaszewski 2015-10-07 301
54301e6f4e910f Jean-Jacques Hiblot 2019-09-20 @302 ret = led_set_brightness_nosleep(led_cdev, value);
54301e6f4e910f Jean-Jacques Hiblot 2019-09-20 303 if (!ret)
54301e6f4e910f Jean-Jacques Hiblot 2019-09-20 304 return ret;
13ae79bbe4c214 Jacek Anaszewski 2015-10-07 305
54301e6f4e910f Jean-Jacques Hiblot 2019-09-20 306 flush_work(&led_cdev->set_brightness_work);
13ae79bbe4c214 Jacek Anaszewski 2015-10-07 307 return 0;
13ae79bbe4c214 Jacek Anaszewski 2015-10-07 308 }
13ae79bbe4c214 Jacek Anaszewski 2015-10-07 309 EXPORT_SYMBOL_GPL(led_set_brightness_sync);
13ae79bbe4c214 Jacek Anaszewski 2015-10-07 310
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 52132 bytes --]
next prev parent reply other threads:[~2019-09-21 16:07 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-20 12:25 [PATCH v4 0/3] leds: Add control of the voltage/current regulator to the LED core Jean-Jacques Hiblot
2019-09-20 12:25 ` [PATCH v4 1/3] led: make led_set_brightness_sync() use led_set_brightness_nosleep() Jean-Jacques Hiblot
2019-09-20 21:10 ` Jacek Anaszewski
2019-09-23 9:14 ` Jean-Jacques Hiblot
2019-09-23 21:03 ` Jacek Anaszewski
2019-09-24 13:43 ` Jean-Jacques Hiblot
2019-09-21 16:13 ` kbuild test robot [this message]
2019-09-20 12:25 ` [PATCH v4 2/3] dt-bindings: leds: document the "power-supply" property Jean-Jacques Hiblot
2019-09-20 12:25 ` [PATCH v4 3/3] leds: Add control of the voltage/current regulator to the LED core Jean-Jacques Hiblot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190921161335.GG13569@xsang-OptiPlex-9020 \
--to=lkp@intel.com \
--cc=daniel.thompson@linaro.org \
--cc=dmurphy@ti.com \
--cc=jacek.anaszewski@gmail.com \
--cc=jjhiblot@ti.com \
--cc=kbuild-all@01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=tomi.valkeinen@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).