From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C77B7C4740A for ; Sun, 22 Sep 2019 03:07:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9604E20820 for ; Sun, 22 Sep 2019 03:07:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=netronome-com.20150623.gappssmtp.com header.i=@netronome-com.20150623.gappssmtp.com header.b="PnxsGTDp" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727381AbfIVDHq (ORCPT ); Sat, 21 Sep 2019 23:07:46 -0400 Received: from mail-pg1-f194.google.com ([209.85.215.194]:34962 "EHLO mail-pg1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727076AbfIVDHp (ORCPT ); Sat, 21 Sep 2019 23:07:45 -0400 Received: by mail-pg1-f194.google.com with SMTP id a24so5989702pgj.2 for ; Sat, 21 Sep 2019 20:07:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netronome-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :organization:mime-version:content-transfer-encoding; bh=+hqtxIPOF+sZTV83QO8Kx8GfXMOFqFAUA+8V0ZE+ANg=; b=PnxsGTDplcToYRHyOkbs7IReY50O0iFBh50FWIfgtGYFlX3h1/1GwJvwb31v/YSjbq L5q4X0jVPfEfZtz5YgmePdWf2L5dKEZewSTNrH1rcE4wL/wF4WxwDh9lINZqLJOU9nOW PV67ZVl5AokgCmzu6JZTfRKLIfSzrQm2fs6UAiweCvvZvBvFqghogOV/+EiwPJyv713d E04dW4DMzi2hzAh7XTAWD7QJSMJdu8sMi57XO8EHnrxfUKqPGX2au03up6gTUiM1xZlP EzXX3qUnta4jQ5/nDXheTTOcehl8cV0QIBckQL2JlvvfkpTb17qPjIAJ+XeT0UZ4DNrF wLTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:organization:mime-version:content-transfer-encoding; bh=+hqtxIPOF+sZTV83QO8Kx8GfXMOFqFAUA+8V0ZE+ANg=; b=baYrzBGU0huB7rPRamjiGdVyQxok99SVbfMVJysqzqAGReSqCQ50gmqtHsb3oou/PI q9Z/u/qlpGNJqjQrhsXFlZUSdiHtRBB9S8EopUhd5Hb9TFFkZEC3PA76Q9ZYBiPcf89H gywILA23N52Xeym2zqOOHwQDa7GsPfTOMbEo6bAOOViypg/mgKN71iynX2c1dpEDuUya JAkM2xjp1KOjpeO7vuDG/FCEVKlhPfiNgMY+8mL1wQHX9yXQfcSBTx13XmtCpSYTLImL TdDASAVYo/adUhMsAGkuxh/HzVgp+hU6Vg5vATxGv4beeGV2WfVM7bD/PvmLW9IvlOPt k3RQ== X-Gm-Message-State: APjAAAUtu9N8cMqvRTQJIh8djNIgVYy2YpMbkRF0iEQ0AiN0grxX4MIF qhuWL0u0QTyzs0uXLLNYD/idvw== X-Google-Smtp-Source: APXvYqx/D1qo8iYkkLBA9WBqzVmvZ7s4hPuIRi3UELaObvTRIfbYaVT/1L8MrpqY7PNd85MaIjz5VQ== X-Received: by 2002:a65:6081:: with SMTP id t1mr21324171pgu.95.1569121664868; Sat, 21 Sep 2019 20:07:44 -0700 (PDT) Received: from cakuba.netronome.com (c-73-202-202-92.hsd1.ca.comcast.net. [73.202.202.92]) by smtp.gmail.com with ESMTPSA id t125sm10316640pfc.80.2019.09.21.20.07.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 21 Sep 2019 20:07:44 -0700 (PDT) Date: Sat, 21 Sep 2019 20:07:41 -0700 From: Jakub Kicinski To: Mao Wenan Cc: , , , , , , , Uwe =?UTF-8?B?S2xlaW5lLUvDtm5pZw==?= Subject: Re: [PATCH net] net: ena: Add dependency for ENA_ETHERNET Message-ID: <20190921200741.1c3289e8@cakuba.netronome.com> In-Reply-To: <20190920084405.140750-1-maowenan@huawei.com> References: <20190920084405.140750-1-maowenan@huawei.com> Organization: Netronome Systems, Ltd. MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 20 Sep 2019 16:44:05 +0800, Mao Wenan wrote: > If CONFIG_ENA_ETHERNET=y and CONFIG_DIMLIB=n, > below erros can be found: > drivers/net/ethernet/amazon/ena/ena_netdev.o: In function `ena_dim_work': > ena_netdev.c:(.text+0x21cc): undefined reference to `net_dim_get_rx_moderation' > ena_netdev.c:(.text+0x21cc): relocation truncated to > fit: R_AARCH64_CALL26 against undefined symbol `net_dim_get_rx_moderation' > drivers/net/ethernet/amazon/ena/ena_netdev.o: In function `ena_io_poll': > ena_netdev.c:(.text+0x7bd4): undefined reference to `net_dim' > ena_netdev.c:(.text+0x7bd4): relocation truncated to fit: > R_AARCH64_CALL26 against undefined symbol `net_dim' > > After commit 282faf61a053 ("net: ena: switch to dim algorithm for rx adaptive > interrupt moderation"), it introduces dim algorithm, which configured by CONFIG_DIMLIB. > > Fixes: 282faf61a053 ("net: ena: switch to dim algorithm for rx adaptive interrupt moderation") > Signed-off-by: Mao Wenan Thank you Mao, shortly after you posted your patch Uwe proposed to make DIMLIB a hidden symbol: https://lore.kernel.org/netdev/a85be675-ce56-f7ba-29e9-b749073aab6c@kleine-koenig.org/T/#t That patch will likely be applied soon, could you please rework your patch to use the "select" keyword instead of "depends". That's what other users do. > diff --git a/drivers/net/ethernet/amazon/Kconfig b/drivers/net/ethernet/amazon/Kconfig > index 69ca99d..fe46df4 100644 > --- a/drivers/net/ethernet/amazon/Kconfig > +++ b/drivers/net/ethernet/amazon/Kconfig > @@ -18,7 +18,7 @@ if NET_VENDOR_AMAZON > > config ENA_ETHERNET > tristate "Elastic Network Adapter (ENA) support" > - depends on PCI_MSI && !CPU_BIG_ENDIAN > + depends on PCI_MSI && !CPU_BIG_ENDIAN && DIMLIB > ---help--- > This driver supports Elastic Network Adapter (ENA)" >