From: Pavel Machek <pavel@ucw.cz>
To: Anson Huang <Anson.Huang@nxp.com>
Cc: robh+dt@kernel.org, mark.rutland@arm.com, shawnguo@kernel.org,
s.hauer@pengutronix.de, kernel@pengutronix.de,
festevam@gmail.com, catalin.marinas@arm.com, will@kernel.org,
dmitry.torokhov@gmail.com, aisheng.dong@nxp.com,
ulf.hansson@linaro.org, fugang.duan@nxp.com, peng.fan@nxp.com,
daniel.baluta@nxp.com, leonard.crestez@nxp.com,
mripard@kernel.org, olof@lixom.net, arnd@arndb.de,
jagan@amarulasolutions.com, bjorn.andersson@linaro.org,
dinguyen@kernel.org, marcin.juszkiewicz@linaro.org,
stefan@agner.ch, gregkh@linuxfoundation.org,
andriy.shevchenko@linux.intel.com, yuehaibing@huawei.com,
tglx@linutronix.de, ronald@innovation.ch,
m.felsch@pengutronix.de, ping.bai@nxp.com,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-input@vger.kernel.org, Linux-imx@nxp.com
Subject: Re: [PATCH V2 1/5] dt-bindings: fsl: scu: add scu power key binding
Date: Sun, 22 Sep 2019 18:14:15 +0200 [thread overview]
Message-ID: <20190922161415.GD1999@bug> (raw)
In-Reply-To: <1567519424-32271-1-git-send-email-Anson.Huang@nxp.com>
On Tue 2019-09-03 10:03:40, Anson Huang wrote:
> NXP i.MX8QXP is an ARMv8 SoC with a Cortex-M4 core inside as
> system controller, the system controller is in charge of system
> power, clock and power key event etc. management, Linux kernel
> has to communicate with system controller via MU (message unit)
> IPC to get power key event, add binding doc for i.MX system
> controller power key driver.
>
> Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
> ---
> Changes since V1:
> - remove "wakeup-source" property, as it is NOT needed for SCU interrupt;
> - remove "status" in example.
> ---
> .../devicetree/bindings/arm/freescale/fsl,scu.txt | 14 ++++++++++++++
> 1 file changed, 14 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt b/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt
> index c149fad..f93e2e4 100644
> --- a/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt
> +++ b/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt
> @@ -157,6 +157,15 @@ Required properties:
> Optional properties:
> - timeout-sec: contains the watchdog timeout in seconds.
>
> +Power key bindings based on SCU Message Protocol
> +------------------------------------------------------------
> +
> +Required properties:
> +- compatible: should be:
> + "fsl,imx8qxp-sc-pwrkey"
> + followed by "fsl,imx-sc-pwrkey";
> +- linux,keycodes: See Documentation/devicetree/bindings/input/keys.txt
Note you have keycode_s_ here, but keycode in the example and in the dts patch.
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
next prev parent reply other threads:[~2019-09-22 16:14 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-03 14:03 [PATCH V2 1/5] dt-bindings: fsl: scu: add scu power key binding Anson Huang
2019-09-03 6:32 ` Oleksij Rempel
2019-09-03 6:37 ` Anson Huang
2019-09-03 6:47 ` Oleksij Rempel
2019-09-03 6:55 ` Anson Huang
2019-09-03 14:03 ` [PATCH V2 2/5] input: keyboard: imx_sc: Add i.MX system controller power key support Anson Huang
2019-09-03 2:38 ` Fabio Estevam
2019-09-03 3:11 ` Anson Huang
2019-09-03 6:12 ` Dmitry Torokhov
2019-09-03 6:29 ` Oleksij Rempel
2019-09-03 6:48 ` Anson Huang
2019-09-03 7:28 ` Oleksij Rempel
2019-09-03 7:35 ` Anson Huang
2019-09-03 7:43 ` Oleksij Rempel
2019-09-22 16:14 ` Pavel Machek
2019-09-03 14:03 ` [PATCH V2 3/5] arm64: dts: imx8qxp: Add scu power key node Anson Huang
2019-09-03 14:03 ` [PATCH V2 4/5] arm64: dts: imx8qxp-mek: Enable scu power key Anson Huang
2019-09-03 14:03 ` [PATCH V2 5/5] arm64: defconfig: Enable CONFIG_KEYBOARD_IMX_SC_PWRKEY as module Anson Huang
2019-09-22 16:13 ` [PATCH V2 1/5] dt-bindings: fsl: scu: add scu power key binding Pavel Machek
2019-09-23 2:31 ` Anson Huang
2019-09-22 16:14 ` Pavel Machek [this message]
2019-09-23 2:34 ` Anson Huang
2019-10-06 0:32 ` Shawn Guo
2019-10-07 1:29 ` Anson Huang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190922161415.GD1999@bug \
--to=pavel@ucw.cz \
--cc=Anson.Huang@nxp.com \
--cc=Linux-imx@nxp.com \
--cc=aisheng.dong@nxp.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=arnd@arndb.de \
--cc=bjorn.andersson@linaro.org \
--cc=catalin.marinas@arm.com \
--cc=daniel.baluta@nxp.com \
--cc=devicetree@vger.kernel.org \
--cc=dinguyen@kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=festevam@gmail.com \
--cc=fugang.duan@nxp.com \
--cc=gregkh@linuxfoundation.org \
--cc=jagan@amarulasolutions.com \
--cc=kernel@pengutronix.de \
--cc=leonard.crestez@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=m.felsch@pengutronix.de \
--cc=marcin.juszkiewicz@linaro.org \
--cc=mark.rutland@arm.com \
--cc=mripard@kernel.org \
--cc=olof@lixom.net \
--cc=peng.fan@nxp.com \
--cc=ping.bai@nxp.com \
--cc=robh+dt@kernel.org \
--cc=ronald@innovation.ch \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=stefan@agner.ch \
--cc=tglx@linutronix.de \
--cc=ulf.hansson@linaro.org \
--cc=will@kernel.org \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).