From: Arvind Sankar <nivedita@alum.mit.edu>
To: linux-kernel@vger.kernel.org
Cc: Nick Desaulniers <ndesaulniers@google.com>
Subject: kexec broken with STACKLEAK enabled
Date: Sun, 22 Sep 2019 13:32:42 -0400 [thread overview]
Message-ID: <20190922173241.GA44503@rani.riverdale.lan> (raw)
Hi, since commit b059f801a937 (x86/purgatory: Use CFLAGS_REMOVE rather
than reset KBUILD_CFLAGS) kexec is broken if GCC_PLUGIN_STACKLEAK is
enabled, as the purgatory contains undefined references to
stackleak_track_stack.
Attempting to load a kexec kernel results in an error:
kexec: Undefined symbol: stackleak_track_stack
kexec-bzImage64: Loading purgatory failed
Adding $(DISABLE_STACKLEAK_PLUGIN) to PURGATORY_CFLAGS in
arch/x86/purgatory/Makefile fixes this.
Not sure if that's the best fix or if other architectures also require a
similar one.
Thanks.
next reply other threads:[~2019-09-22 17:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-22 17:32 Arvind Sankar [this message]
2019-09-23 16:15 ` kexec broken with STACKLEAK enabled Nick Desaulniers
2019-09-23 17:17 ` [PATCH] x86/purgatory: Add $(DISABLE_STACKLEAK_PLUGIN) Arvind Sankar
2019-09-23 17:25 ` Nick Desaulniers
2019-09-23 17:52 ` [tip: x86/urgent] x86/purgatory: Disable the stackleak GCC plugin for the purgatory tip-bot2 for Arvind Sankar
2019-09-23 17:52 ` tip-bot2 for Arvind Sankar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190922173241.GA44503@rani.riverdale.lan \
--to=nivedita@alum.mit.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=ndesaulniers@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).