From: Wei Yang <richardw.yang@linux.intel.com>
To: Dave Hansen <dave.hansen@intel.com>
Cc: Wei Yang <richardw.yang@linux.intel.com>,
dave.hansen@linux.intel.com, luto@kernel.org,
peterz@infradead.org, x86@kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86/mm: fix return value of p[um]dp_set_access_flags
Date: Mon, 23 Sep 2019 14:00:05 +0800 [thread overview]
Message-ID: <20190923060005.GB7750@richard> (raw)
In-Reply-To: <2fde036a-f64e-ce58-65bf-a089e7c673aa@intel.com>
On Fri, Sep 20, 2019 at 09:16:12AM -0700, Dave Hansen wrote:
>On 9/19/19 7:18 PM, Wei Yang wrote:
>> Last but not least, since update_mmu_cache_pmd is empty, even return
>> value is not correct, it doesn't break anything.
>
>In other words, this patch has no functional effect and does not provide
>a "fix". What's the point of patching this stuff if it has no effect?
It correct the function semantics. The return value of these function doesn't
meet the requirement, which will be misleading and we still need to dig in the
history to find out the correct answer.
In case we would have a valid cache update mechanism, this would introduce a
problem.
So I suggest to fix the return value to reflect the true meaning.
--
Wei Yang
Help you, Help me
prev parent reply other threads:[~2019-09-23 6:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-19 8:25 [PATCH] x86/mm: fix return value of p[um]dp_set_access_flags Wei Yang
2019-09-19 17:25 ` Dave Hansen
2019-09-20 2:18 ` Wei Yang
2019-09-20 16:16 ` Dave Hansen
2019-09-23 6:00 ` Wei Yang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190923060005.GB7750@richard \
--to=richardw.yang@linux.intel.com \
--cc=dave.hansen@intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=peterz@infradead.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).