From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 704A6C4740C for ; Mon, 23 Sep 2019 06:38:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4C71220882 for ; Mon, 23 Sep 2019 06:38:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2404682AbfIWGiJ (ORCPT ); Mon, 23 Sep 2019 02:38:09 -0400 Received: from mx1.redhat.com ([209.132.183.28]:40938 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387519AbfIWGiJ (ORCPT ); Mon, 23 Sep 2019 02:38:09 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id CF375883CA; Mon, 23 Sep 2019 06:38:08 +0000 (UTC) Received: from sirius.home.kraxel.org (ovpn-116-47.ams2.redhat.com [10.36.116.47]) by smtp.corp.redhat.com (Postfix) with ESMTP id 1997B5D713; Mon, 23 Sep 2019 06:38:05 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id E120F9D6A; Mon, 23 Sep 2019 08:38:03 +0200 (CEST) Date: Mon, 23 Sep 2019 08:38:03 +0200 From: Gerd Hoffmann To: Daniel Vetter Cc: Alexander Kapshuk , Christian =?utf-8?B?S8O2bmln?= , dri-devel , linux-next , Linux Kernel Mailing List , Maarten Lankhorst , Maxime Ripard , Sean Paul , Dave Airlie Subject: Re: Kernel panic during drm/nouveau init 5.3.0-rc7-next-20190903 Message-ID: <20190923063803.c7zpqwcqq5f2acq5@sirius.home.kraxel.org> References: <20190907090534.GB1712@pc-sasha.localdomain> <20190920194450.GA3970@pc-sasha.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: NeoMutt/20180716 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Mon, 23 Sep 2019 06:38:09 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > > 'Git bisect' has identified the following commits as being 'bad'. > > > > b96f3e7c8069b749a40ca3a33c97835d57dd45d2 is the first bad commit > > commit b96f3e7c8069b749a40ca3a33c97835d57dd45d2 > > Author: Gerd Hoffmann > > Date: Mon Aug 5 16:01:10 2019 +0200 > > > > drm/ttm: use gem vma_node > > > > Drop vma_node from ttm_buffer_object, use the gem struct > > (base.vma_node) instead. > > > > Signed-off-by: Gerd Hoffmann > > Reviewed-by: Christian König > > Link: http://patchwork.freedesktop.org/patch/msgid/20190805140119.7337-9-kraxel@redhat.com > > Today, I upgraded the kernel to 5.3.0-next-20190919, which booted fine > > with no Xorg regressions to report. > > > > Just wondering if the earlier kernels would not boot for me because of > > the changes introduced by the 'bad' commits being perhaps incomplete? Yes, we had a regression in nouveau, fixed by this patch (in drm-misc-next): commit 019cbd4a4feb3aa3a917d78e7110e3011bbff6d5 Author: Thierry Reding Date: Wed Aug 14 11:00:48 2019 +0200 drm/nouveau: Initialize GEM object before TTM object TTM assumes that drivers initialize the embedded GEM object before calling the ttm_bo_init() function. This is not currently the case in the Nouveau driver. Fix this by splitting up nouveau_bo_new() into nouveau_bo_alloc() and nouveau_bo_init() so that the GEM can be initialized before TTM BO initialization when necessary. Fixes: b96f3e7c8069 ("drm/ttm: use gem vma_node") Acked-by: Gerd Hoffmann Acked-by: Ben Skeggs Signed-off-by: Thierry Reding Link: https://patchwork.freedesktop.org/patch/msgid/20190814093524.GA31345@ulmo HTH, Gerd