From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 17361C3A5A6 for ; Mon, 23 Sep 2019 08:20:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E14D620835 for ; Mon, 23 Sep 2019 08:20:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2437765AbfIWIUq (ORCPT ); Mon, 23 Sep 2019 04:20:46 -0400 Received: from www62.your-server.de ([213.133.104.62]:42736 "EHLO www62.your-server.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2392126AbfIWIUp (ORCPT ); Mon, 23 Sep 2019 04:20:45 -0400 Received: from [178.197.248.15] (helo=localhost) by www62.your-server.de with esmtpsa (TLSv1.2:DHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89_1) (envelope-from ) id 1iCJaJ-0007z4-U5; Mon, 23 Sep 2019 10:20:40 +0200 Date: Mon, 23 Sep 2019 10:20:39 +0200 From: Daniel Borkmann To: Andrii Nakryiko Cc: Kefeng Wang , Joe Perches , Andrew Morton , Ingo Molnar , "David S. Miller" , Arnaldo Carvalho de Melo , Andy Whitcroft , Peter Zijlstra , Alexei Starovoitov , Greg Kroah-Hartman , Sergey Senozhatsky , Petr Mladek , Arnd Bergmann , open list , Martin KaFai Lau , Song Liu , Yonghong Song , bpf Subject: Re: [PATCH 30/32] tools lib bpf: Renaming pr_warning to pr_warn Message-ID: <20190923082039.GA2530@pc-63.home> References: <20190920062544.180997-1-wangkefeng.wang@huawei.com> <20190920062544.180997-31-wangkefeng.wang@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.12.1 (2019-06-15) X-Authenticated-Sender: daniel@iogearbox.net X-Virus-Scanned: Clear (ClamAV 0.101.4/25580/Sun Sep 22 10:23:13 2019) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Sep 22, 2019 at 02:07:21PM -0700, Andrii Nakryiko wrote: > On Fri, Sep 20, 2019 at 10:06 AM Kefeng Wang wrote: > > > > For kernel logging macro, pr_warning is completely removed and > > replaced by pr_warn, using pr_warn in tools lib bpf for symmetry > > to kernel logging macro, then we could drop pr_warning in the > > whole linux code. > > > > Cc: Alexei Starovoitov > > Cc: Daniel Borkmann > > Cc: Martin KaFai Lau > > Cc: Song Liu > > Cc: Yonghong Song > > Cc: bpf@vger.kernel.org > > Signed-off-by: Kefeng Wang > > --- > > tools/lib/bpf/btf.c | 56 +-- > > tools/lib/bpf/btf_dump.c | 20 +- > > tools/lib/bpf/libbpf.c | 652 ++++++++++++++++---------------- > > tools/lib/bpf/libbpf_internal.h | 2 +- > > tools/lib/bpf/xsk.c | 4 +- > > 5 files changed, 363 insertions(+), 371 deletions(-) > > Thanks! This will allow to get rid of tons warnings from checkpatch.pl. > > Alexei, Daniel, can we take this through bpf-next tree once it's open? I'd be fine with that, in fact, it probably should be in order to avoid merge conflicts since pr_warn{ing}() is used all over the place in libbpf. Kefeng would then however also need to include the original patch which adds the pr_warn() to tools in the first place. > Acked-by: Andrii Nakryiko > > [...]