From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E3F07C32755 for ; Mon, 23 Sep 2019 11:03:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C61F321841 for ; Mon, 23 Sep 2019 11:03:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2392779AbfIWLDK (ORCPT ); Mon, 23 Sep 2019 07:03:10 -0400 Received: from mx2.suse.de ([195.135.220.15]:54536 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S2387421AbfIWLDJ (ORCPT ); Mon, 23 Sep 2019 07:03:09 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id B4835AED6; Mon, 23 Sep 2019 11:03:07 +0000 (UTC) Date: Mon, 23 Sep 2019 13:03:06 +0200 From: Petr Mladek To: Daniel Borkmann , Linus Torvalds Cc: Andrii Nakryiko , Arnd Bergmann , Andy Whitcroft , "David S. Miller" , Martin KaFai Lau , Song Liu , Yonghong Song , Sergey Senozhatsky , Kefeng Wang , Peter Zijlstra , Alexei Starovoitov , Andrew Morton , Greg Kroah-Hartman , Joe Perches , Arnaldo Carvalho de Melo , Ingo Molnar , bpf , open list Subject: Re: [PATCH 30/32] tools lib bpf: Renaming pr_warning to pr_warn Message-ID: <20190923110306.hrgeqwo5ogd55vfo@pathway.suse.cz> References: <20190920062544.180997-1-wangkefeng.wang@huawei.com> <20190920062544.180997-31-wangkefeng.wang@huawei.com> <20190923082039.GA2530@pc-63.home> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190923082039.GA2530@pc-63.home> User-Agent: NeoMutt/20170912 (1.9.0) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon 2019-09-23 10:20:39, Daniel Borkmann wrote: > On Sun, Sep 22, 2019 at 02:07:21PM -0700, Andrii Nakryiko wrote: > > On Fri, Sep 20, 2019 at 10:06 AM Kefeng Wang wrote: > > > > > > For kernel logging macro, pr_warning is completely removed and > > > replaced by pr_warn, using pr_warn in tools lib bpf for symmetry > > > to kernel logging macro, then we could drop pr_warning in the > > > whole linux code. > > > > > > Signed-off-by: Kefeng Wang > > > --- > > > tools/lib/bpf/btf.c | 56 +-- > > > tools/lib/bpf/btf_dump.c | 20 +- > > > tools/lib/bpf/libbpf.c | 652 ++++++++++++++++---------------- > > > tools/lib/bpf/libbpf_internal.h | 2 +- > > > tools/lib/bpf/xsk.c | 4 +- > > > 5 files changed, 363 insertions(+), 371 deletions(-) > > > > Thanks! This will allow to get rid of tons warnings from checkpatch.pl. > > > > Alexei, Daniel, can we take this through bpf-next tree once it's open? > > I'd be fine with that, in fact, it probably should be in order to avoid > merge conflicts since pr_warn{ing}() is used all over the place in libbpf. The entire patchset modifies many files all over the tree. This is from https://lkml.kernel.org/r/20190920062544.180997-1-wangkefeng.wang@huawei.com 120 files changed, 882 insertions(+), 927 deletions(-) Would it make sense to push everything at the end of the merge window or for 5.4-rc2 after master settles down? Best Regards, Petr