From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4E6F9C4CECF for ; Mon, 23 Sep 2019 15:49:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2C4152089F for ; Mon, 23 Sep 2019 15:49:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387484AbfIWPtM (ORCPT ); Mon, 23 Sep 2019 11:49:12 -0400 Received: from mx1.redhat.com ([209.132.183.28]:49420 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728551AbfIWPtM (ORCPT ); Mon, 23 Sep 2019 11:49:12 -0400 Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 934C580F7C for ; Mon, 23 Sep 2019 15:49:11 +0000 (UTC) Received: by mail-qt1-f199.google.com with SMTP id y10so17839818qti.1 for ; Mon, 23 Sep 2019 08:49:11 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=DtFe2+5JtbV/OwUJETgyRdR0XjjvYqOvroBO1aiGGnE=; b=Wvr0puzAl3GpiE6lbkIAdJo4hikHbGQY4AXH+nK3KY0/ol9NJLScQcxRREPPeaQbgd dvygB1Tm/haNtn9FF544LtpWQF/geRHO3iYM5Bv3snMRdPurT+FbQYjJm3/EAJXuFgt8 TX1M5nRRWezcMzyukQwZXGsoE7yszb7qYnLYMvEFZQy2D/wXdbiC2OEUhwmn/DhXdsBe S7Ak2BPa2V9dk1JUKCw+dGQL+ASuauICG4sKFnrfGwqUR9zIZZlqfafZ5s4YWwt9+ksf zg6s8NOSiciXgQJJHexRkIiZGw5+SNn500Vu8QN64wRWey5R8CwNbP0boLZ895VA67MK g9qw== X-Gm-Message-State: APjAAAVzgS5YxindT3vNmeMRHdgAFl3GTnjVv3UIgbucc9GmwyFXJbxm 5/3HElAlwhkUv2NVqssE56C2aVySl4KSyI/k9O7JSuIGU4Zex4qaQbJSbhctmn1z5trDcVjj6vM DD+bXZP/Dp95oO/TS5S12iFUD X-Received: by 2002:a37:f61e:: with SMTP id y30mr500110qkj.208.1569253750897; Mon, 23 Sep 2019 08:49:10 -0700 (PDT) X-Google-Smtp-Source: APXvYqzol6drxsIFmKvmhlgbnLArJa9kxX+uy/D+M1Of/zo/DzG9baRX9vu805PC9WY2snt/4bzaNA== X-Received: by 2002:a37:f61e:: with SMTP id y30mr500077qkj.208.1569253750741; Mon, 23 Sep 2019 08:49:10 -0700 (PDT) Received: from redhat.com (bzq-79-176-40-226.red.bezeqint.net. [79.176.40.226]) by smtp.gmail.com with ESMTPSA id v5sm7307386qtk.66.2019.09.23.08.49.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Sep 2019 08:49:09 -0700 (PDT) Date: Mon, 23 Sep 2019 11:49:01 -0400 From: "Michael S. Tsirkin" To: David Hildenbrand Cc: Alexander Duyck , virtio-dev@lists.oasis-open.org, kvm list , Dave Hansen , LKML , Matthew Wilcox , Michal Hocko , linux-mm , Vlastimil Babka , Andrew Morton , Mel Gorman , linux-arm-kernel@lists.infradead.org, Oscar Salvador , Yang Zhang , Pankaj Gupta , Konrad Rzeszutek Wilk , Nitesh Narayan Lal , Rik van Riel , lcapitulino@redhat.com, "Wang, Wei W" , Andrea Arcangeli , Paolo Bonzini , Dan Williams , Alexander Duyck Subject: Re: [PATCH v10 3/6] mm: Introduce Reported pages Message-ID: <20190923114840-mutt-send-email-mst@kernel.org> References: <20190918175109.23474.67039.stgit@localhost.localdomain> <20190918175249.23474.51171.stgit@localhost.localdomain> <20190923041330-mutt-send-email-mst@kernel.org> <20190923105746-mutt-send-email-mst@kernel.org> <20190923113722-mutt-send-email-mst@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 23, 2019 at 05:45:29PM +0200, David Hildenbrand wrote: > On 23.09.19 17:37, Michael S. Tsirkin wrote: > > On Mon, Sep 23, 2019 at 08:28:00AM -0700, Alexander Duyck wrote: > >> On Mon, Sep 23, 2019 at 8:00 AM Michael S. Tsirkin wrote: > >>> > >>> On Mon, Sep 23, 2019 at 07:50:15AM -0700, Alexander Duyck wrote: > >>>>>> +static inline void > >>>>>> +page_reporting_reset_boundary(struct zone *zone, unsigned int order, int mt) > >>>>>> +{ > >>>>>> + int index; > >>>>>> + > >>>>>> + if (order < PAGE_REPORTING_MIN_ORDER) > >>>>>> + return; > >>>>>> + if (!test_bit(ZONE_PAGE_REPORTING_ACTIVE, &zone->flags)) > >>>>>> + return; > >>>>>> + > >>>>>> + index = get_reporting_index(order, mt); > >>>>>> + reported_boundary[index] = &zone->free_area[order].free_list[mt]; > >>>>>> +} > >>>>> > >>>>> So this seems to be costly. > >>>>> I'm guessing it's the access to flags: > >>>>> > >>>>> > >>>>> /* zone flags, see below */ > >>>>> unsigned long flags; > >>>>> > >>>>> /* Primarily protects free_area */ > >>>>> spinlock_t lock; > >>>>> > >>>>> > >>>>> > >>>>> which is in the same cache line as the lock. > >>>> > >>>> I'm not sure what you mean by this being costly? > >>> > >>> I've just been wondering why does will it scale report a 1.5% regression > >>> with this patch. > >> > >> Are you talking about data you have collected from a test you have > >> run, or the data I have run? > > > > About the kernel test robot auto report that was sent recently. > > https://lkml.org/lkml/2019/9/21/112 > > And if I'm correct, that regression is observable in case reporting is > not enabled. (so with this patch applied only, e.g., on a bare-metal system) Exactly. That's what makes it interesting. > > -- > > Thanks, > > David / dhildenb