From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.7 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 91966C4CEC4 for ; Mon, 23 Sep 2019 15:53:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 67D572089F for ; Mon, 23 Sep 2019 15:53:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="P/TbzBez" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732851AbfIWPxT (ORCPT ); Mon, 23 Sep 2019 11:53:19 -0400 Received: from mail-io1-f66.google.com ([209.85.166.66]:33771 "EHLO mail-io1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728464AbfIWPxS (ORCPT ); Mon, 23 Sep 2019 11:53:18 -0400 Received: by mail-io1-f66.google.com with SMTP id z19so12480561ior.0; Mon, 23 Sep 2019 08:53:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=ah97PWhBQllHvUmQP5lNKcxTltHIduIyS/x+VCiBzGk=; b=P/TbzBez5vHy8/yao1OuiUgpxf3Qd4RJaODHAMLc4UVmKtiEiJosxcV7cmYSjs2fyn VHCKPSeu+3nIeu4R1Ez0EDXGTXbq/8swT5bIhSyA1278jBzBlu4cFlyAweACoyzCQqis r1K3szwlpCsN3a4/PPK9WIJB2l9JTr3ZkTNBC8hD6ZqF+gw9tUVvvZPji+UF6Tq1+Y+r Ls2n8QKv8X59r7DIWtgPqpgX2bBEypETlCk6yhNfwWknBM6BckJz/3PqK/D1GNQEYz6u PEP0Ah7OVyvdAr6/FbFSdDTgBr7nc3uCQMIfbXIJBTbIxAj6ClfD3VS/QS4NZ9Hrowxy qmqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=ah97PWhBQllHvUmQP5lNKcxTltHIduIyS/x+VCiBzGk=; b=WJXhHZEgTa7rsdYMlHgeK69hS0TYtm28yg7P3S6KDQngVoRn+VqeIBqzpaJI2yP41M DgKt3/NcZ/ftjCIPgOek08Hj8HFI5EPhGZvyWd9RdIGbQ2bUMyr14sh3jO14SjQ1WX6+ /kRJnDSxedpsck1T3Zw82MZvWQ2w7nCd0JCebxAuhMcDrPtcel1ugAusUZMhW8tvtCog x/gXmX6pvPgfqj0CaeeCFJgKLbkwmqtuTUfRjTJf09r7DQGe0au+zqKMc2uumVK2UiEr dHcZYI+5uQQMLkz2ngg6gxHH/EKvt3v1fFWM/JBDCSnguGSMo8l07l8j+Wwsgiue3ZAf sD5Q== X-Gm-Message-State: APjAAAXuHkdBhq+Ia9HQ4b8m00Y5jndXfpXWTPfgfY4ht3lr103dyq+S 3kiYFj6sibMuDfZD3bOMQ6E= X-Google-Smtp-Source: APXvYqxSEa3nkHQJ8qte5MAQfQVcainVzehT8UD0UrHT1LadXl/4J9G4yT0WS/80QXvLOZ2tJhZVSA== X-Received: by 2002:a5e:9e04:: with SMTP id i4mr25866429ioq.175.1569253996678; Mon, 23 Sep 2019 08:53:16 -0700 (PDT) Received: from cs-dulles.cs.umn.edu (cs-dulles.cs.umn.edu. [128.101.35.54]) by smtp.googlemail.com with ESMTPSA id c5sm8463116ioq.61.2019.09.23.08.53.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Sep 2019 08:53:16 -0700 (PDT) From: Navid Emamdoost To: leon@kernel.org Cc: emamd001@umn.edu, smccaman@umn.edu, kjlu@umn.edu, Navid Emamdoost , Potnuri Bharat Teja , Doug Ledford , Jason Gunthorpe , linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2] RDMA: release allocated skb Date: Mon, 23 Sep 2019 10:52:59 -0500 Message-Id: <20190923155300.20407-1-navid.emamdoost@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190923050823.GL14368@unreal> References: <20190923050823.GL14368@unreal> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org In create_cq, the allocated skb buffer needs to be released on error path. Moved the kfree_skb(skb) under err4 label. Signed-off-by: Navid Emamdoost --- drivers/infiniband/hw/cxgb4/cq.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/infiniband/hw/cxgb4/cq.c b/drivers/infiniband/hw/cxgb4/cq.c index b1bb61c65f4f..1886c1af10bc 100644 --- a/drivers/infiniband/hw/cxgb4/cq.c +++ b/drivers/infiniband/hw/cxgb4/cq.c @@ -173,6 +173,7 @@ static int create_cq(struct c4iw_rdev *rdev, struct t4_cq *cq, err4: dma_free_coherent(&rdev->lldi.pdev->dev, cq->memsize, cq->queue, dma_unmap_addr(cq, mapping)); + kfree_skb(skb); err3: kfree(cq->sw_queue); err2: -- 2.17.1